Skip to content

Cherry pick #12182 to 20.4: Cap max_memory_usage* limits to the process resident memory#12831

Merged
alexey-milovidov merged 5 commits intobackport/20.4/12182from
cherrypick/20.4/072a8e0e40f79c23a28db217d66d20e59f98d769
Jul 27, 2020
Merged

Cherry pick #12182 to 20.4: Cap max_memory_usage* limits to the process resident memory#12831
alexey-milovidov merged 5 commits intobackport/20.4/12182from
cherrypick/20.4/072a8e0e40f79c23a28db217d66d20e59f98d769

Conversation

@robot-clickhouse
Copy link
Member

Original pull-request #12182

This pull-request is a first step of an automated backporting.
It contains changes like after calling a local command git cherry-pick.
If you intend to continue backporting this changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.

The check results does not matter at this step - you can safely ignore them.
Also this pull-request will be merged automatically as it reaches the mergeable state, but you always can merge it manually.

azat and others added 4 commits July 7, 2020 01:51
There are still some issues with memory tracking, but now with per-user
tracking:

    executeQuery: Code: 241, e.displayText() = DB::Exception: Memory limit (for user) exceeded: would use 437.72 GiB (attempt to allocate chunk of 4200926 bytes), maximum: 437.72 GiB (version 20.6.1.1) (from 10.7.140.7:31318)

Although the server is mostly idle:

    SELECT formatReadableSize(memory_usage)
    FROM system.processes

    ┌─formatReadableSize(memory_usage)─┐
    │ 289.28 MiB                       │
    │ 155.75 MiB                       │
    │ 0.00 B                           │
    └──────────────────────────────────┘

Refs: https://github.com/ClickHouse/ClickHouse/pull/10496/files#r450206865
Cc: @alexey-milovidov
Cap max_memory_usage* limits to the process resident memory
@robot-clickhouse robot-clickhouse added do not test disable testing on pull request pr-cherrypick Cherry-pick of merge-commit before backporting. Do not use manually - automated use only! labels Jul 27, 2020
@alexey-milovidov alexey-milovidov merged this pull request into backport/20.4/12182 Jul 27, 2020
@alexey-milovidov alexey-milovidov deleted the cherrypick/20.4/072a8e0e40f79c23a28db217d66d20e59f98d769 branch July 27, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not test disable testing on pull request pr-cherrypick Cherry-pick of merge-commit before backporting. Do not use manually - automated use only!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants