Skip to content

Enable codespell#13513

Merged
alexey-milovidov merged 8 commits intomasterfrom
codespell-2
Aug 16, 2020
Merged

Enable codespell#13513
alexey-milovidov merged 8 commits intomasterfrom
codespell-2

Conversation

@alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Enable check for typos in code with codespell.

Detailed description / Documentation draft:
Based on #13511 + integration to style check.
It requires pip3 install codespell (or maybe apt-get install is also ok?).
But I did not found the Dockerfile for style check.

@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label Aug 8, 2020
@qoega
Copy link
Member

qoega commented Aug 10, 2020

It requires pip3 install codespell (or maybe apt-get install is also ok?).

There in no container for style check https://nda.ya.ru/t/uQY4n48E3WUUDb
Probably we can create one.

@alexey-milovidov alexey-milovidov marked this pull request as ready for review August 16, 2020 11:59
@alexey-milovidov
Copy link
Member Author

Apparently, tests run before Docker container rebuilds.

@alexey-milovidov
Copy link
Member Author

Push to dockerhub — Updated yandex/clickhouse-style-test

Ok.

@alexey-milovidov alexey-milovidov merged commit 810829d into master Aug 16, 2020
@alexey-milovidov alexey-milovidov deleted the codespell-2 branch August 16, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted pr-build Pull request with build/testing/packaging improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants