Skip to content

[WIP] OS X 10.12 build#159

Merged
alexey-milovidov merged 1 commit intomasterfrom
chebotarev-osx
Nov 3, 2016
Merged

[WIP] OS X 10.12 build#159
alexey-milovidov merged 1 commit intomasterfrom
chebotarev-osx

Conversation

@excitoon
Copy link
Contributor

@excitoon excitoon commented Nov 2, 2016

No description provided.

doc/build_osx.md Outdated
## Install required libraries from packages

```
brew install icu4c mysql boost protobuf msgpack openssl unixodbc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

msgpack and protobuf are not needed.

@excitoon excitoon changed the title [WIP] 10.12 OS X 10.12 build Nov 3, 2016
@excitoon excitoon changed the title OS X 10.12 build [WIP] OS X 10.12 build Nov 3, 2016
find_library (ICUUC libicuuc.a HINTS ${ICU_HINTS})
find_library (ICUDATA libicudata.a HINTS ${ICU_HINTS})
set (ICU_LIBS ${ICUI18N} ${ICUUC} ${ICUDATA})

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be only for OS X?

Copy link
Contributor Author

@excitoon excitoon Nov 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this may be valid for any OS and distribution, possibly with small additions into HINTS. Generally, it is a common practice to access external libraries in CMake projects.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but paths in hits looks too specific. Don't mind.

@alexey-milovidov alexey-milovidov merged commit 3d05948 into master Nov 3, 2016
@excitoon
Copy link
Contributor Author

excitoon commented Nov 3, 2016

@Civil
I wonder if mentioning somebody invites him into a PR.

liuneng1994 added a commit to liuneng1994/ClickHouse that referenced this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants