Merged
Conversation
doc/build_osx.md
Outdated
| ## Install required libraries from packages | ||
|
|
||
| ``` | ||
| brew install icu4c mysql boost protobuf msgpack openssl unixodbc |
Member
There was a problem hiding this comment.
msgpack and protobuf are not needed.
826cead to
e2ceb63
Compare
alexey-milovidov
approved these changes
Nov 3, 2016
| find_library (ICUUC libicuuc.a HINTS ${ICU_HINTS}) | ||
| find_library (ICUDATA libicudata.a HINTS ${ICU_HINTS}) | ||
| set (ICU_LIBS ${ICUI18N} ${ICUUC} ${ICUDATA}) | ||
|
|
Member
There was a problem hiding this comment.
This must be only for OS X?
Contributor
Author
There was a problem hiding this comment.
Well, this may be valid for any OS and distribution, possibly with small additions into HINTS. Generally, it is a common practice to access external libraries in CMake projects.
Member
There was a problem hiding this comment.
Ok, but paths in hits looks too specific. Don't mind.
Contributor
Author
|
@Civil |
liuneng1994
added a commit
to liuneng1994/ClickHouse
that referenced
this pull request
Oct 18, 2022
…lickHouse#128)" (ClickHouse#159) This reverts commit 729900c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.