Skip to content

Add file paths into logs on failed distributed async sends#23856

Merged
kitaisreal merged 1 commit intoClickHouse:masterfrom
azat:dist-send-improve-logging
May 3, 2021
Merged

Add file paths into logs on failed distributed async sends#23856
kitaisreal merged 1 commit intoClickHouse:masterfrom
azat:dist-send-improve-logging

Conversation

@azat
Copy link
Member

@azat azat commented May 3, 2021

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@azat azat changed the title Add information about files on failed distributed async sends Add file paths into logs on failed distributed async sends May 3, 2021
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 3, 2021
@azat azat force-pushed the dist-send-improve-logging branch from 95ab986 to 9361000 Compare May 3, 2021 05:39
@azat azat marked this pull request as draft May 3, 2021 05:53
@azat azat force-pushed the dist-send-improve-logging branch from 9361000 to 5e33604 Compare May 3, 2021 05:56
@azat azat marked this pull request as ready for review May 3, 2021 11:41
@kitaisreal kitaisreal self-assigned this May 3, 2021
@kitaisreal kitaisreal merged commit ea7ea99 into ClickHouse:master May 3, 2021
@azat azat deleted the dist-send-improve-logging branch May 3, 2021 20:51
azat added a commit to azat/ClickHouse that referenced this pull request Feb 3, 2023
…tch")

There was an error from the begginning that does not respect
file_indices, and iterate only over file_index_to_path, while this is
not correct, since there can be less files then in file_index_to_path,
and this is what file_indices for.

Note, that only an error message was wrong, logic was fine. You can
verify this by the logs:

    2022.12.07 11:55:50.951976 [ 39217 ] {} <Debug> default.dist.DirectoryMonitor: Sending a batch of 10 files to localhost:9000 (128.42 thousand rows, 36.32 MiB bytes).
    2022.12.07 11:55:50.953762 [ 39217 ] {} <Error> default.dist.DirectoryMonitor: Code: 516. DB::Exception: Received from localhost:9000. DB::Exception: Interserver authentication failed. Stack trace:
    ...
    : While sending batch, nums: 62, files: /work6/clickhouse/data/default/dist/shard1_replica1/66827258.bin

As you can see "Sending a batch of 10 files" but "nums: 62"

Fixes: ClickHouse#23856
Refs: ClickHouse#41813
Signed-off-by: Azat Khuzhin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants