Skip to content

add simple sanity checks for server startup#34566

Merged
alesapin merged 20 commits intomasterfrom
startup-sanity-checks
Mar 31, 2022
Merged

add simple sanity checks for server startup#34566
alesapin merged 20 commits intomasterfrom
startup-sanity-checks

Conversation

@serxa
Copy link
Member

@serxa serxa commented Feb 13, 2022

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
added sanity checks on server startup (available memory and disk space, max thread count, etc)

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 13, 2022
@serxa serxa changed the title add simple sanity checks for server startup #18794 add simple sanity checks for server startup Feb 14, 2022
@serxa
Copy link
Member Author

serxa commented Feb 14, 2022

this PR makes several checks from the list mentioned in #18794

@robot-clickhouse robot-clickhouse added pr-improvement Pull request with some product improvements and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Feb 14, 2022
@alesapin alesapin self-assigned this Feb 14, 2022
return 0;
uint64_t available_pages = vmt.t_avm;
#else
uint64_t available_pages = sysconf(_SC_AVPHYS_PAGES);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work for darwin.

@alesapin
Copy link
Member

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 24, 2022

update

✅ Branch has been successfully updated

@alesapin
Copy link
Member

Waiting only for builds, style check unrelated.

@alesapin
Copy link
Member

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2022

update

✅ Branch has been successfully updated

@alesapin
Copy link
Member

Failures look unrelated but let's check one more time.

@alesapin
Copy link
Member

Failures unrelated to changes (checked log for postgres test)

@alesapin alesapin merged commit 2365bbf into master Mar 31, 2022
@alesapin alesapin deleted the startup-sanity-checks branch March 31, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants