Allow restrictive row policies without permissive#34596
Merged
vitlibar merged 4 commits intoClickHouse:masterfrom Feb 19, 2022
Merged
Allow restrictive row policies without permissive#34596vitlibar merged 4 commits intoClickHouse:masterfrom
vitlibar merged 4 commits intoClickHouse:masterfrom
Conversation
5fb3f9d to
4419776
Compare
added 4 commits
February 17, 2022 14:18
… restrictive" before "TO" clause.
…e result filter won't be calculated as False always anymore.
4419776 to
a4ef274
Compare
Member
Author
|
Stateless tests flaky check: The test |
vitlibar
pushed a commit
to vitlibar/ClickHouse
that referenced
this pull request
Feb 24, 2022
…equired' which enables the change in mixing row policies' filters implemented in ClickHouse#34596
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category:
Changelog entry:
This PR changes restrictive row policies a bit to make them an easier alternative to permissive policies in easy cases.
If for a particular table only restrictive policies exist (without permissive policies) users will be able to see some rows.
Also
SHOW CREATE ROW POLICYwill always showAS permissiveorAS restrictivein row policy's definition.For example, if we have three users
John,Lucy, andAlexand following policies:then with the changes of this PR
Johnwill see rows witha=1,Lucywill see rows witha=2andAlexwill see any rows.Before this PR permissive policies were always required to see anything, so in the above example anybody would see nothing.