Skip to content

Try to run stateful tests in parallel#35720

Merged
alesapin merged 5 commits intomasterfrom
parallel_stateful
Mar 30, 2022
Merged

Try to run stateful tests in parallel#35720
alesapin merged 5 commits intomasterfrom
parallel_stateful

Conversation

@tavplubix
Copy link
Member

@tavplubix tavplubix commented Mar 29, 2022

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Because after #33717 (merged on 2022-03-11, added minio, test.hits_s3 table and new long test) and #35047 (merged on 2022-03-24, added max_threads randomization) 1 hour is not enough to run all stateful tests sometimes:

Example: https://s3.amazonaws.com/clickhouse-test-reports/0/9a8e9198e59c4cf0b3b7204ada83e87bdf845590/stateful_tests__thread__actions_/runlog.log

Average check time:

TSan became 20 minutes longer since 2022-03-11 and 10 minutes longer since 2022-03-24

Debug became 3 minutes longer since 2022-03-11 and 5 minutes longer since 2022-03-24

@tavplubix tavplubix mentioned this pull request Mar 29, 2022
Merged
@alesapin alesapin self-assigned this Mar 30, 2022
@alesapin
Copy link
Member

alesapin commented Mar 30, 2022

@Mergifyio upodate

@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2022

Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@alesapin
Copy link
Member

alesapin commented Mar 30, 2022

https://github.com/Mergifyio update

@alesapin
Copy link
Member

alesapin commented Mar 30, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2022

update

✅ Branch has been successfully updated

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 30, 2022
@tavplubix
Copy link
Member Author

tavplubix commented Mar 30, 2022

c37945b: Stateful tests (thread, actions) - 00170_s3_cache - server crashed with no stacktrace, cc: @kssenii
I marked 00170_s3_cache as no-parallel to make tests pass. Probably it was due to high memory usage, but need to check.

@tavplubix
Copy link
Member Author

tavplubix commented Mar 30, 2022

All stateful tests checks passed.
Stateful tests (thread, actions):

2022-03-30 12:34:39 Using queries from '/usr/share/clickhouse-test/queries' directory
...
2022-03-30 13:10:45 All tests have finished.

So it takes about 36 minutes. Current timeout for clickhouse-test is 60*0.9=54 minutes.

@tavplubix
Copy link
Member Author

tavplubix commented Mar 30, 2022

Integration tests (release, actions) [1/2] - test_merge_tree_azure_blob_storage/test.py::test_freeze_unfreeze - Azure::Storage::StorageException: 404 The specified blob does not exist., cc: @jkuklis, @kssenii
Integration tests (release, actions) [2/2] - test_replicated_merge_tree_encryption_codec/test.py::test_different_nonces - assert '1\tstr1\n' == 1 str1\n2 str2, cc: @vitlibar
Style Check (actions) - tests/ci/clickhouse_helper.py - was broken in master, already fixed

@alesapin
Copy link
Member

alesapin commented Mar 30, 2022

Let's merge then.

@alesapin alesapin merged commit 5a55913 into master Mar 30, 2022
@alesapin alesapin deleted the parallel_stateful branch March 30, 2022 21:42
@azat azat mentioned this pull request Mar 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alesapin alesapin

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tavplubix @alesapin @robot-clickhouse