ci: replace directory system log tables artifacts with tsv#35773
Merged
tavplubix merged 1 commit intoClickHouse:masterfrom Mar 31, 2022
Merged
ci: replace directory system log tables artifacts with tsv#35773tavplubix merged 1 commit intoClickHouse:masterfrom
tavplubix merged 1 commit intoClickHouse:masterfrom
Conversation
robot-ch-test-poll
added
the
pr-not-for-changelog
Member
Author
Here is an example 1: |
tavplubix
approved these changes
Mar 30, 2022
azat
force-pushed
the
stateless-tests-artifacts
branch
from
af3119a to
1483e96
Compare
tavplubix
reviewed
Mar 30, 2022
Changelog: - remove query_thread_log (query_log should be enough) - for s3 storage there /var/lib/clickhouse/data/system/*_log cannot be used, replace them with plain TSVWithNamesAndTypes, also note, that after schema inference it is even pretty easy to use - support replicated database env correctly Co-authored-by: tavplubix <[email protected]> Signed-off-by: Azat Khuzhin <[email protected]>
azat
force-pushed
the
stateless-tests-artifacts
branch
from
1483e96 to
8b84829
Compare
Member
Author
|
Artifacts looks good (checked zookeeper_log fo s3 storage, databasereplicated and regular) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog:
used, replace them with plain TSVWithNamesAndTypes, also note, that
after schema inference it is even pretty easy to use
Changelog category (leave one):