Skip to content

remove ATOMIC_FLAG_INIT: depreciated in C++20 and warns in clang-14#35785

Merged
antonio2368 merged 1 commit intoClickHouse:masterfrom
justnoise:remove-atomic-flag-init
Mar 31, 2022
Merged

remove ATOMIC_FLAG_INIT: depreciated in C++20 and warns in clang-14#35785
antonio2368 merged 1 commit intoClickHouse:masterfrom
justnoise:remove-atomic-flag-init

Conversation

@justnoise
Copy link
Contributor

@justnoise justnoise commented Mar 31, 2022

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Information about CI checks: https://clickhouse.tech/docs/en/development/continuous-integration/

Background: I attempted to build on Ubuntu 20.04 using the latest version of clang downloaded via https://apt.llvm.org/llvm.sh but it seems like a recent change in clang (https://reviews.llvm.org/D112221) leads to the following build failure: error: macro 'ATOMIC_FLAG_INIT' has been marked as depreciated

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2022

CLA assistant check
All committers have signed the CLA.

@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label Mar 31, 2022
@antonio2368 antonio2368 self-assigned this Mar 31, 2022
@antonio2368 antonio2368 added the can be tested Allows running workflows for external contributors label Mar 31, 2022
@antonio2368 antonio2368 merged commit 1d48017 into ClickHouse:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-build Pull request with build/testing/packaging improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants