Revert "Apply upstream jemalloc patch for potential leak"#4018
Merged
alexey-milovidov merged 1 commit intomasterfrom Jan 9, 2019
Merged
Revert "Apply upstream jemalloc patch for potential leak"#4018alexey-milovidov merged 1 commit intomasterfrom
alexey-milovidov merged 1 commit intomasterfrom
Conversation
alexey-milovidov
added a commit
that referenced
this pull request
Jan 11, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Jan 11, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Jan 11, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Jan 11, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Jan 11, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Jan 11, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Jan 14, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Jan 14, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Jan 15, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Jan 15, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Jan 15, 2019
This reverts commit 510b155.
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Feb 22, 2019
Otherwise std::thread will call std::terminate() from the dtor: ... ClickHouse#4 0x000000000ac829c1 in std::terminate() () ClickHouse#5 0x0000000006f1c87f in std::thread::~thread (this=<optimized out>, __in_chrg=<optimized out>) at /usr/include/c++/7/thread:135 ... ClickHouse#10 ThreadPoolImpl<std::thread>::worker (this=0xf370680 <ext::singleton<GlobalThreadPool>::instance()::instance>, thread_it=...) at ../dbms/src/Common/ThreadPool.cpp:191 Refs: f6b9b06 ("Attempt to implemnt global thread pool ClickHouse#4018")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3557 due to major performance degradation.