Skip to content

Revert "Remove redundant sorting"#45414

Merged
tavplubix merged 1 commit intomasterfrom
revert-43905-igor/remove_redundant_order_by
Jan 18, 2023
Merged

Revert "Remove redundant sorting"#45414
tavplubix merged 1 commit intomasterfrom
revert-43905-igor/remove_redundant_order_by

Conversation

@devcrafter
Copy link
Member

@devcrafter devcrafter commented Jan 18, 2023

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 18, 2023
@tavplubix tavplubix merged commit 85f32d8 into master Jan 18, 2023
@tavplubix tavplubix deleted the revert-43905-igor/remove_redundant_order_by branch January 18, 2023 18:46
@tavplubix
Copy link
Member

tavplubix commented Jan 18, 2023

Also looks like #43905 has broken performance tests

@devcrafter devcrafter mentioned this pull request Jan 18, 2023
Merged
@devcrafter
Copy link
Member Author

devcrafter commented Jan 19, 2023

Also looks like #43905 has broken performance tests

It introduces new setting and use it performance test here. So, since there is no such setting in previous version sort.xml perf test failed

@tavplubix tavplubix mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devcrafter @tavplubix @robot-ch-test-poll4