Revert "Merge pull request #44922 from azat/dist/async-INSERT-metrics"#45492
Merged
tavplubix merged 1 commit intoClickHouse:masterfrom Jan 21, 2023
Merged
Conversation
…RT-metrics" There are the following problems with this patch: - Looses files on exception - Existing current_batch.txt on startup leads to ENOENT error and hung of distributed sends without ATTACH/DETACH - Race between creating the queue for sending at table startup and INSERT, if it had been created from INSERT, then it will not be initialized from disk They were addressed in ClickHouse#45491, but it makes code more cmoplex and plus since, likely, the release is comming, it is better to revert the change. This reverts commit 94604f7, reversing changes made to 80f6a45.
robot-ch-test-poll4
added
the
pr-not-for-changelog
Member
Author
|
@tavplubix Merged too fast, there was some conflicts although they were trivial and it does complies, but I hope that nothing will pops up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Revert "Merge pull request #44922 from azat/dist/async-INSERT-metrics"
There are the following problems with this patch:
They were addressed in #45491, but it makes code more cmoplex and plus since, likely, the release is comming, it is better to revert the change.
This reverts commit 94604f7, reversing changes made to 80f6a45.
Note, marked as
Not for changelogsince the buggy patch had not been included into any release.Cc: @tavplubix