Merged
Conversation
robot-ch-test-poll4
added
the
pr-not-for-changelog
alexey-milovidov
approved these changes
Feb 17, 2023
Member
Author
|
|
azat
reviewed
Feb 18, 2023
Comment on lines
-549
to
-550
| if (task->reader.valid()) | ||
| task->reader.wait(); |
Member
There was a problem hiding this comment.
@kssenii I was looking into this too, so just to ensure that I'm we are on the same page, do I understand correctly that the problem was that not all features are kept in the MergeTreePrefetchedReadPool (getTask moves it out), hence some of the got lost and not waited properly?
Member
Author
There was a problem hiding this comment.
Yes, correct, according to the logs of stress test, the query was killed by the memory overcommit tracker and that is why it was not waited properly for some of the tasks which were already collected with getTask, but the same can also happen if some exception is thrown after the thread collected the task with getTask and before extracting the readers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):