reinitialize primary key after ALTER#516
Merged
alexey-milovidov merged 1 commit intomasterfrom Feb 21, 2017
Merged
Conversation
ztlpn
commented
Feb 20, 2017
| data.initPrimaryKey(); | ||
| } | ||
| /// Reinitialize primary key because primary key column types might have changed. | ||
| data.initPrimaryKey(); |
Contributor
Author
There was a problem hiding this comment.
We could calculate if the PK column types have really changed and reinitialize only in that case.
But just doing it in any case is simpler and shouldn't do any harm.
lgbo-ustc
pushed a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Apr 8, 2025
Fix rebase issue: - 20250306 ClickHouse#76662 Co-authored-by: liuneng1994 <[email protected]>
baibaichen
pushed a commit
to baibaichen/ClickHouse
that referenced
this pull request
Apr 22, 2025
Fix rebase issue: - 20250416 ClickHouse#78485 - 20250306 ClickHouse#76662 Co-authored-by: liuneng1994 <[email protected]>
baibaichen
pushed a commit
to baibaichen/ClickHouse
that referenced
this pull request
Jun 8, 2025
Fix rebase issue: - 20250604 ClickHouse#79649 - 20250502 ClickHouse#79180 - 20250416 ClickHouse#78485 - 20250306 ClickHouse#76662 Co-authored-by: liuneng1994 <[email protected]>
baibaichen
pushed a commit
to baibaichen/ClickHouse
that referenced
this pull request
Jun 8, 2025
Fix rebase issue: - 20250604 ClickHouse#79649 - 20250502 ClickHouse#79180 - 20250416 ClickHouse#78485 - 20250306 ClickHouse#76662 Co-authored-by: liuneng1994 <[email protected]>
baibaichen
pushed a commit
to baibaichen/ClickHouse
that referenced
this pull request
Jun 8, 2025
Fix rebase issue: - 20250604 ClickHouse#79649 - 20250502 ClickHouse#79180 - 20250416 ClickHouse#78485 - 20250306 ClickHouse#76662 Co-authored-by: liuneng1994 <[email protected]>
baibaichen
pushed a commit
to baibaichen/ClickHouse
that referenced
this pull request
Jun 8, 2025
Fix rebase issue: - 20250604 ClickHouse#79649 - 20250502 ClickHouse#79180 - 20250416 ClickHouse#78485 - 20250306 ClickHouse#76662 Co-authored-by: liuneng1994 <[email protected]>
lgbo-ustc
pushed a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Sep 17, 2025
Fix rebase issue: - 20250728 ClickHouse#84180 - 20250713 ClickHouse#82949 - 20250703 ClickHouse#82934 - 20250626 ClickHouse#80931 - 20250604 ClickHouse#79649 - 20250502 ClickHouse#79180 - 20250416 ClickHouse#78485 - 20250306 ClickHouse#76662 Co-authored-by: liuneng1994 <[email protected]>
lgbo-ustc
pushed a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Oct 29, 2025
Fix rebase issue: - 20250728 ClickHouse#84180 - 20250713 ClickHouse#82949 - 20250703 ClickHouse#82934 - 20250626 ClickHouse#80931 - 20250604 ClickHouse#79649 - 20250502 ClickHouse#79180 - 20250416 ClickHouse#78485 - 20250306 ClickHouse#76662 Co-authored-by: liuneng1994 <[email protected]>
Onyx2406
pushed a commit
to Onyx2406/ClickHouse
that referenced
this pull request
Mar 19, 2026
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#512