Skip to content

Added integration test for session_log using concurrrent GRPC/PostgreSQL/MySQL sessions#53305

Merged
tavplubix merged 2 commits intoClickHouse:masterfrom
arenadata:ADQM-1011-integration_test_session_log
Aug 16, 2023
Merged

Added integration test for session_log using concurrrent GRPC/PostgreSQL/MySQL sessions#53305
tavplubix merged 2 commits intoClickHouse:masterfrom
arenadata:ADQM-1011-integration_test_session_log

Conversation

@Demilivor
Copy link
Contributor

@Demilivor Demilivor commented Aug 11, 2023

This PR is a part of previously reverted PR
Added test for session_log using concurrent GRPC/PostgreSQL/MySQL sessions.

PostgreSQL test case temporary skipped because of these fails: #53255 (comment)

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@Demilivor Demilivor mentioned this pull request Aug 11, 2023
Merged
@tavplubix tavplubix self-assigned this Aug 11, 2023
@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Aug 12, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 12, 2023
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Aug 12, 2023 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit 0e17288 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🔴 failure
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success

@Demilivor Demilivor changed the title [DRAFT] Added integration test for session_log using concurrrent GRPC/PostgreSQL/MySQL sessions Added integration test for session_log using concurrrent GRPC/PostgreSQL/MySQL sessions Aug 13, 2023
@alexey-milovidov
Copy link
Member

alexey-milovidov commented Aug 13, 2023

@tavplubix looks 🟢 surprisingly 🍏 green 🌲

@Demilivor
Copy link
Contributor Author

Demilivor commented Aug 15, 2023

The failing test test_postgres_session is temporary disabled.

@Demilivor
Copy link
Contributor Author

Demilivor commented Aug 15, 2023

ClickHouse several PostgreSQL tests broken:

https://github.com/ClickHouse/ClickHouse/blob/33763e7e50d283d2ad08b7e831c9494c9043ba2f/tests/analyzer_integration_broken_tests.txt#L98C6-L98C25

ClickHouse/tests/analyzer_integration_broken_tests.txt

Line 85 in 33763e7

test_storage_postgresql/test.py::test_postgres_select_insert

I can rewrite the test using the native PostgreSQL client psql instead of disabling it and give the test another chance.

@Demilivor Demilivor force-pushed the ADQM-1011-integration_test_session_log branch from eb633dc to 2aa211a Compare August 15, 2023 13:27
@Demilivor
Copy link
Contributor Author

Demilivor commented Aug 15, 2023

Update: changed psycopg2 to native psql client.

@tavplubix
Copy link
Member

tavplubix commented Aug 15, 2023

ClickHouse several PostgreSQL tests broken:
https://github.com/ClickHouse/ClickHouse/blob/33763e7e50d283d2ad08b7e831c9494c9043ba2f/tests/analyzer_integration_broken_tests.txt#L98C6-L98C25

This list is related to "Analyzer", it's a new feature that is currently being developed, and some tests don't work with allow_experimental_analyzer=1. The new test for session_log was failing without Analyzer too (example), so it's not related

@Demilivor
Copy link
Contributor Author

Demilivor commented Aug 15, 2023

Ok, thanks for explaining.  It corresponds to this query.  So this test was the only failing test with postgres substring in name

@tavplubix
Copy link
Member

tavplubix commented Aug 16, 2023

Integration tests are ok, the rest checks are entirely broken by #53354 and similar PRs

@tavplubix tavplubix merged commit c85e2ec into ClickHouse:master Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tavplubix tavplubix

Labels

can be tested Allows running workflows for external contributors pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Demilivor @robot-clickhouse-ci-2 @alexey-milovidov @tavplubix