Skip to content

Added test for session_log using concurrrent TCP/HTTP/MySQL sessions#53306

Merged
tavplubix merged 1 commit intoClickHouse:masterfrom
arenadata:ADQM-1011-test_concurrent_sessions
Aug 16, 2023
Merged

Added test for session_log using concurrrent TCP/HTTP/MySQL sessions#53306
tavplubix merged 1 commit intoClickHouse:masterfrom
arenadata:ADQM-1011-test_concurrent_sessions

Conversation

@Demilivor
Copy link
Contributor

@Demilivor Demilivor commented Aug 11, 2023

This PR is a part of previously reverted PR
Added test for session_log using concurrent TCP/HTTP/MySQL Sessions.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@Demilivor Demilivor mentioned this pull request Aug 11, 2023
Merged
@tavplubix tavplubix self-assigned this Aug 11, 2023
@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Aug 12, 2023
@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 12, 2023
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Aug 12, 2023 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit cbf9f88 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success

@Demilivor Demilivor changed the title [DRAFT] Added test for session_log using concurrrent TCP/HTTP/MySQL sessions Added test for session_log using concurrrent TCP/HTTP/MySQL sessions Aug 13, 2023
@Demilivor
Copy link
Contributor Author

Demilivor commented Aug 15, 2023

Was can be tested added before PR or after? If after, then failing this and other sh tests confuses me. I'm going to rebase my code on master and push again to restart the tests.

@tavplubix
Copy link
Member

tavplubix commented Aug 15, 2023

Was can be tested added before #53302 or after?

It was, I guess

@Demilivor Demilivor force-pushed the ADQM-1011-test_concurrent_sessions branch from 99f22aa to cbf9f88 Compare August 15, 2023 13:42
@tavplubix tavplubix mentioned this pull request Aug 16, 2023
Merged
tavplubix added a commit that referenced this pull request Aug 16, 2023
@tavplubix
Merge pull request #53473 from ClickHouse/merging_53306
2f81d87 
Merging #53306
@tavplubix tavplubix merged commit 1cd384a into ClickHouse:master Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tavplubix tavplubix

Labels

can be tested Allows running workflows for external contributors pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Demilivor @robot-ch-test-poll @tavplubix @alexey-milovidov