Skip to content

KeyCondition IN function support different types#54544

Merged
KochetovNicolai merged 6 commits intoClickHouse:masterfrom
kitaisreal:key-condition-in-function-different-types
Sep 20, 2023
Merged

KeyCondition IN function support different types#54544
KochetovNicolai merged 6 commits intoClickHouse:masterfrom
kitaisreal:key-condition-in-function-different-types

Conversation

@kitaisreal
Copy link
Contributor

@kitaisreal kitaisreal commented Sep 12, 2023 •
edited
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Allow to use primary key for IN function where primary key column types are different from IN function right side column types. Example: SELECT id FROM test_table WHERE id IN (SELECT '5'). Closes #48936.

@kitaisreal kitaisreal added the can be tested Allows running workflows for external contributors label Sep 12, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-improvement Pull request with some product improvements label Sep 12, 2023
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Sep 12, 2023 •
edited by robot-ch-test-poll3
Loading

This is an automated comment for commit 27d8eef with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@kitaisreal kitaisreal force-pushed the key-condition-in-function-different-types branch from 82c5915 to 6005e14 Compare September 12, 2023 14:32
@KochetovNicolai KochetovNicolai self-assigned this Sep 13, 2023
KochetovNicolai
KochetovNicolai reviewed Sep 14, 2023
View reviewed changes
src/Storages/MergeTree/RPNBuilder.cpp Outdated
Copy link
Member

@KochetovNicolai KochetovNicolai Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really happy that this part of code is removed :)

@kitaisreal kitaisreal force-pushed the key-condition-in-function-different-types branch from 604dac1 to 912e2db Compare September 14, 2023 16:54
@kitaisreal kitaisreal force-pushed the key-condition-in-function-different-types branch from 04f1926 to 1539a92 Compare September 15, 2023 14:05
KochetovNicolai
KochetovNicolai reviewed Sep 18, 2023
View reviewed changes
KochetovNicolai
KochetovNicolai reviewed Sep 18, 2023
View reviewed changes
KochetovNicolai
KochetovNicolai requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@KochetovNicolai KochetovNicolai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the tiny bug in canBeSafelyCasted

@kitaisreal kitaisreal force-pushed the key-condition-in-function-different-types branch from 7b4a209 to c7ddbab Compare September 19, 2023 10:06
@KochetovNicolai KochetovNicolai merged commit 0bc41ba into ClickHouse:master Sep 20, 2023
@jrdi jrdi mentioned this pull request Sep 20, 2023
Closed
@antaljanosbenjamin antaljanosbenjamin mentioned this pull request Oct 18, 2023
Merged
2 tasks
@ilejn ilejn mentioned this pull request Nov 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KochetovNicolai KochetovNicolai KochetovNicolai approved these changes

Assignees

@KochetovNicolai KochetovNicolai

Labels

can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Analyzer: Subquery filter not using primary key

9 participants

@kitaisreal @robot-clickhouse-ci-2 @KochetovNicolai @robot-clickhouse @robot-ch-test-poll @robot-ch-test-poll2 @robot-ch-test-poll4 @robot-ch-test-poll3 @robot-clickhouse-ci-1