Skip to content

Update 00002_log_and_exception_messages_formatting.sql#58012

Merged
tavplubix merged 1 commit intomasterfrom
tavplubix-patch-9
Dec 20, 2023
Merged

Update 00002_log_and_exception_messages_formatting.sql#58012
tavplubix merged 1 commit intomasterfrom
tavplubix-patch-9

Conversation

@tavplubix
Copy link
Member

@tavplubix tavplubix commented Dec 18, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

https://s3.amazonaws.com/clickhouse-test-reports/57682/f876bea0500e3d150609b2cd79878dd04d36b2dd/stateless_tests__tsan__s3_storage__[5_5].html

2023-12-08 19:00:08 -runtime messages	0.001
2023-12-08 19:00:08 +runtime messages	0.0011781789961961984

2023-12-08 19:00:32 Top messages without format string (fmt::runtime):
2023-12-08 19:00:32 
2023-12-08 19:00:32 count	pattern	runtime_message	line
2023-12-08 19:00:32 UInt64	String	String	Tuple(String, UInt64)
2023-12-08 19:00:32 224	IfthesignaturecheckfailedThiscou	If the signature check failed. This could be because of a time skew. Attempting to adjust the signer.	('/AWSLogger.cpp',71)
2023-12-08 19:00:32 221	Failedtomakerequesttohttplocalho	Failed to make request to: http://localhost:11111/test/test/qgg/tyhbplkrxyhdpqtinrlansfkwyqce: Poco::Exception. Code: 1000, e.code() = 0, Timeout, Stack trace (when copying this message, always include the lines below):\n\n0. ./contrib/llvm-project/libcxx/in	('/PocoHTTPClient.cpp',610)
2023-12-08 19:00:32 221	Requestfailednowwaitingmsbeforea	Request failed, now waiting 0 ms before attempting again.	('/AWSLogger.cpp',71)
2023-12-08 19:00:32 40	EntryconnectionPINGok	Entry(connection 0): PING ok.	('',0)
2023-12-08 19:00:32 40	EntryconnectionsendingPINGtochec	Entry(connection 0): sending PING to check if it is alive.	('',0)

@tavplubix tavplubix mentioned this pull request Dec 18, 2023
Merged
@alexey-milovidov alexey-milovidov self-assigned this Dec 18, 2023
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 18, 2023
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented Dec 18, 2023 •
edited by robot-clickhouse
Loading

This is an automated comment for commit a8ef051 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker server and keeper imagesThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Docs checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@azat azat mentioned this pull request Dec 18, 2023
Merged
@tavplubix
Copy link
Member Author

tavplubix commented Dec 20, 2023

Stateless tests flaky check (asan) - OK
Upgrade check (msan) - #56798

@tavplubix tavplubix merged commit 74a3b8b into master Dec 20, 2023
@tavplubix tavplubix deleted the tavplubix-patch-9 branch December 20, 2023 15:37
@Algunenano Algunenano mentioned this pull request Dec 20, 2023
Merged
@azat azat mentioned this pull request Dec 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tavplubix @robot-ch-test-poll2 @alexey-milovidov