Skip to content

Keep exception format string in retries ctl#58351

Merged
alexey-milovidov merged 3 commits intomasterfrom
fix_00002
Dec 30, 2023
Merged

Keep exception format string in retries ctl#58351
alexey-milovidov merged 3 commits intomasterfrom
fix_00002

Conversation

@tavplubix
Copy link
Member

@tavplubix tavplubix commented Dec 29, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fixes 00002_log_and_exception_messages_formatting:

2023-12-28 20:07:35 00002_log_and_exception_messages_formatting:                            [ FAIL ] 4.16 sec. - having exception in stdout: 
2023-12-28 20:07:35 runtime messages	0.001	[]
2023-12-28 20:07:35 runtime exceptions	0.05	[]
2023-12-28 20:07:35 unknown runtime exceptions	0.010494310668654354	[('Code: 242. DB::Exception: Table is in readonly mode: replica_path=/clickhouse/tables/00993_system_parts_race_condition_drop_zookeeper_test_czb2k8r2/alter_table/replicas/r_8. (TABLE_IS_READ_ONLY) (version 23.13.1.24) (from [::1]:38956) (comment: 00993_system_parts_race_condition_drop_zookeeper.sh) (in query: INSERT INTO alter_table_8 SELECT rand(1), rand(2), 1 / rand(3), toString(rand(4)), [rand(5), rand(6)], rand(7) % 2 ? NULL : generateUUIDv4(), (rand(8), rand(9)) FROM numbers(100000)), Stack trace (when copying this message, always include the lines below):\n\n0. ./build_docker/./src/Common/Exception.cpp:96: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000bae0748 in /usr/lib/debug/usr/bin/clickhouse.debug\n1. ./contrib/llvm-project/libcxx/include/string:1499: DB::ZooKeeperRetriesControl::setUserError(int, String) @ 0x000000000f03f004 in /usr/lib/debug/usr/bin/clickhouse.debug\n2. ./contrib/llvm-project/libcxx/include/string:1499: void DB::ZooKeeperRetriesControl::setUserError<String const&>(int, fmt::v8::basic_format_string<char, fmt::v8::type_identity<String const&>::type>, String const&) @ 0x0000000010d07760 in /usr/lib/debug/usr/bin/clickhouse.debug\n3. ./build_docker/./src/Storages/MergeTree/ReplicatedMergeTreeSink.cpp:0: DB::ReplicatedMergeTreeSinkImpl<false>::commitPart(std::shared_ptr<DB::ZooKeeperWithFaultInjection> const&, std::shared_ptr<DB::IMergeTreeDataPart>&, String const&, unsigned long, bool)::\'lambda1\'()::operator()() const @ 0x0000000010d090a0 in /usr/lib/debug/usr/bin/clickhouse.debug\n4. ./build_docker/./src/Storages/MergeTree/ReplicatedMergeTreeSink.cpp:0: DB::ReplicatedMergeTreeSinkImpl<false>::commitPart(std::shared_ptr<DB::ZooKeeperWithFaultInjection> const&, std::shared_ptr<DB::IMergeTreeDataPart>&, String const&, unsigned long, bool) @ 0x0000000010cff5bc in /usr/lib/debug/usr/bin/clickhouse.debug\n5. ./contrib/llvm-project/libcxx/include/vector:434: DB::ReplicatedMergeTreeSinkImpl<false>::finishDelayedChunk(std::shared_ptr<DB::ZooKeeperWithFaultInjection> const&) @ 0x0000000010cfe6d8 in /usr/lib/debug/usr/bin/clickhouse.debug\n6. ./build_docker/./src/Storages/MergeTree/ReplicatedMergeTreeSink.cpp:0: DB::ReplicatedMergeTreeSinkImpl<false>::consume(DB::Chunk) @ 0x0000000010cfba8c in /usr/lib/debug/usr/bin/clickhouse.debug\n7. ./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:701: DB::SinkToStorage::onConsume(DB::Chunk) @ 0x00000000112379ac in /usr/lib/debug/usr/bin/clickhouse.debug\n8. ./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:701: void std::__function::__policy_invoker<void ()>::__call_impl<std::__function::__default_alloc_func<DB::ExceptionKeepingTransform::work()::$_1, void ()>>(std::__function::__policy_storage const*) @ 0x000000001118a42c in /usr/lib/debug/usr/bin/clickhouse.debug\n9. ./build_docker/./src/Processors/Transforms/ExceptionKeepingTransform.cpp:121: DB::runStep(std::function<void ()>, DB::ThreadStatus*, std::atomic<unsigned long>*) @ 0x000000001118a124 in /usr/lib/debug/usr/bin/clickhouse.debug\n10. ./contrib/llvm-project/libcxx/include/__functional/function.h:818: ? @ 0x0000000011189888 in /usr/lib/debug/usr/bin/clickhouse.debug\n11. ./build_docker/./src/Processors/Executors/ExecutionThreadContext.cpp:52: DB::ExecutionThreadContext::executeTask() @ 0x0000000010f49b2c in /usr/lib/debug/usr/bin/clickhouse.debug\n12. ./build_docker/./src/Processors/Executors/PipelineExecutor.cpp:273: DB::PipelineExecutor::executeStepImpl(unsigned long, std::atomic<bool>*) @ 0x0000000010f41c94 in /usr/lib/debug/usr/bin/clickhouse.debug\n13. ./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:701: DB::PipelineExecutor::execute(unsigned long, bool) @ 0x0000000010f412a0 in /usr/lib/debug/usr/bin/clickhouse.debug\n14. ./build_docker/./src/Processors/Executors/CompletedPipelineExecutor.cpp:57: void std::__function::__policy_invoker<void 
...

@tavplubix tavplubix mentioned this pull request Dec 29, 2023
Merged
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 29, 2023
@robot-clickhouse-ci-1
Copy link
Contributor

robot-clickhouse-ci-1 commented Dec 29, 2023 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit 790eded with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@Algunenano Algunenano self-assigned this Dec 29, 2023
Algunenano
Algunenano approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@Algunenano Algunenano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I had been thinking about how to fix it and I couldn't come up with a simple way such as this.

@alexey-milovidov alexey-milovidov merged commit f058394 into master Dec 30, 2023
@alexey-milovidov alexey-milovidov deleted the fix_00002 branch December 30, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano approved these changes

Assignees

@Algunenano Algunenano

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tavplubix @robot-clickhouse-ci-1 @Algunenano @alexey-milovidov