Skip to content

[RFC] Correctly handle keys with dot in the name in configurations XMLs#58354

Merged
robot-ch-test-poll3 merged 1 commit intoClickHouse:masterfrom
azat:xml-conf-dot
Dec 30, 2023
Merged

[RFC] Correctly handle keys with dot in the name in configurations XMLs#58354
robot-ch-test-poll3 merged 1 commit intoClickHouse:masterfrom
azat:xml-conf-dot

Conversation

@azat
Copy link
Member

@azat azat commented Dec 29, 2023

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Correctly handle keys with dot in the name in configurations XMLs

For this I've added escape of the keys returned by keys() method, and handle this escaping in get*() methods.

@azat
Correctly handle keys with dot in the name in configurations XMLs
9a8b308 
For this I've added escape of the keys returned by keys() method, and
handle this escaping in get*() methods.

Signed-off-by: Azat Khuzhin <[email protected]>
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-improvement Pull request with some product improvements label Dec 29, 2023
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Dec 29, 2023 •
edited
Loading

This is an automated comment for commit 9a8b308 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@alexey-milovidov alexey-milovidov self-assigned this Dec 29, 2023
@robot-ch-test-poll3 robot-ch-test-poll3 merged commit c0290d1 into ClickHouse:master Dec 30, 2023
@azat azat deleted the xml-conf-dot branch December 30, 2023 08:42
@filimonov filimonov mentioned this pull request Jan 3, 2025
Closed
@Dnivd Dnivd mentioned this pull request Jun 17, 2025
Closed
mkmkme added a commit to mkmkme/ClickHouse that referenced this pull request Sep 3, 2025
@mkmkme
Add support for user names in config containing a dot
591b6d7 
For correct config parsing, the dots in the user names have been escaped
for some time [1]. This caused a confusion for some users. This commit
adds optional de-escaping to the config parsing process. In order to
keep the behaviour backwards-compatible, it's been hidden behind the new
config entry `<escape_dot_in_user_name>` which is turned on by default.

Fixes ClickHouse#82026

[1] ClickHouse#58354
mkmkme added a commit to mkmkme/ClickHouse that referenced this pull request Sep 3, 2025
@mkmkme
Add support for user names in config containing a dot
f8b0cc7 
For correct config parsing, the dots in the user names have been escaped
for some time [1]. This caused a confusion for some users. This commit
adds optional de-escaping to the config parsing process. In order to
keep the behaviour backwards-compatible, it's been hidden behind the new
config entry `<escape_dot_in_user_name>` which is turned on by default.

Fixes ClickHouse#82026

[1] ClickHouse#58354
@mkmkme mkmkme mentioned this pull request Sep 3, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@azat @robot-clickhouse-ci-2 @alexey-milovidov @robot-ch-test-poll3