Skip to content

Seperate max_execution_time and max_estimated_execution_time#58402

Merged
jsc0218 merged 4 commits intoClickHouse:masterfrom
zhangyifan27:add_max_estimated_execution_time
Jan 22, 2024
Merged

Seperate max_execution_time and max_estimated_execution_time#58402
jsc0218 merged 4 commits intoClickHouse:masterfrom
zhangyifan27:add_max_estimated_execution_time

Conversation

@zhangyifan27
Copy link
Contributor

@zhangyifan27 zhangyifan27 commented Jan 2, 2024 •
edited
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Adding a setting max_estimated_execution_time to separate max_execution_time and max_estimated_execution_time.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Related issue #12169

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@zhangyifan27 zhangyifan27 force-pushed the add_max_estimated_execution_time branch from 9b321cb to 621eaca Compare January 3, 2024 02:15
@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Jan 5, 2024
@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Jan 5, 2024
@robot-clickhouse
Copy link
Member

robot-clickhouse commented Jan 5, 2024 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit 7e56a2d with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs CheckBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@zhangyifan27 zhangyifan27 force-pushed the add_max_estimated_execution_time branch from 621eaca to 730135f Compare January 7, 2024 04:33
@jsc0218 jsc0218 self-assigned this Jan 12, 2024
@qoega
Copy link
Member

qoega commented Jan 16, 2024

Fail in 02896_max_execution_time_with_break_overflow_mode seems related.

@zhangyifan27
Copy link
Contributor Author

zhangyifan27 commented Jan 19, 2024

Fail in 02896_max_execution_time_with_break_overflow_mode seems related.

I test it by running tests/clickhouse-test 02896_max_execution_time_with_break_overflow_mode locally and it passed. I have no idea why it failed with a timeout error.

@zhangyifan27
Copy link
Contributor Author

zhangyifan27 commented Jan 19, 2024

It seems that the failure only occurs in 'Stateless tests (release, analyzer)', but doesn't occur in 'Stateless tests (release)'. Is there any difference between them?

@jsc0218
Copy link
Contributor

jsc0218 commented Jan 22, 2024

thanks for the fix, and other failed tests are irrelevant I think.

@jsc0218 jsc0218 merged commit 6f3124a into ClickHouse:master Jan 22, 2024
@jsc0218 jsc0218 mentioned this pull request Jan 22, 2024
Closed
@tavplubix
Copy link
Member

tavplubix commented Jan 22, 2024

@jsc0218, it breaks Upgrade Check: https://s3.amazonaws.com/clickhouse-test-reports/39507/fe1e326701b0566881dc7d51793125a911faa07e/upgrade_check__debug_.html

@tavplubix tavplubix mentioned this pull request Jan 22, 2024
Merged
@amosbird amosbird mentioned this pull request Jan 23, 2024
Merged
@Avogar Avogar mentioned this pull request Jan 23, 2024
Merged
@jsc0218
Copy link
Contributor

jsc0218 commented Jan 23, 2024

@jsc0218, it breaks Upgrade Check: https://s3.amazonaws.com/clickhouse-test-reports/39507/fe1e326701b0566881dc7d51793125a911faa07e/upgrade_check__debug_.html

fixed in #59104

@azat
Copy link
Member

azat commented Feb 19, 2024

Maybe max_estimated_execution_time should inherits the value of the max_execution_time if max_estimated_execution_time is not changed?

@robot-clickhouse robot-clickhouse added the pr-backports-created-cloud deprecated label, NOOP label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jsc0218 jsc0218

Labels

can be tested Allows running workflows for external contributors pr-backports-created-cloud deprecated label, NOOP pr-improvement Pull request with some product improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@zhangyifan27 @robot-clickhouse @qoega @jsc0218 @tavplubix @azat @KochetovNicolai @alexey-milovidov