Skip to content

Add data checksums to system.parts_columns table. #5151#5874

Merged
alexey-milovidov merged 8 commits intoClickHouse:masterfrom
nikitamikhaylov:master
Jul 5, 2019
Merged

Add data checksums to system.parts_columns table. #5151#5874
alexey-milovidov merged 8 commits intoClickHouse:masterfrom
nikitamikhaylov:master

Conversation

@nikitamikhaylov
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

  • New Feature

Short description (up to few sentences):
Checksums added to the system.parts_columns table.

#5151

@alexey-milovidov
Copy link
Member

Ok, but we also need to ensure that checksums are output in the same way as in other places in code.
For example, look at CompressedReadBufferBase.cpp:

getHexUIntLowercase(expected_checksum.first) + getHexUIntLowercase(expected_checksum.second)

@nikitamikhaylov
Copy link
Member Author

nikitamikhaylov commented Jul 5, 2019

But if we look deeper in code, we see two inline functions

inline uint64 Uint128Low64(const uint128& x) { return x.first; }
inline uint64 Uint128High64(const uint128& x) { return x.second; }

I used them, but missed the order. I'll rewrite my code without them. Also I used LIMIT in test script, that's why random rows were chosen and some tests failed.

@alexey-milovidov
Copy link
Member

But there is also a difference in lower/upper case.

@alexey-milovidov alexey-milovidov merged commit eb2ffcc into ClickHouse:master Jul 5, 2019
@abyss7 abyss7 added the pr-feature Pull request with new product feature label Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature Pull request with new product feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants