Skip to content

Add missing setting max_estimated_execution_time in SettingsChangesHistory#59104

Merged
Avogar merged 2 commits intomasterfrom
Avogar-patch-1
Jan 23, 2024
Merged

Add missing setting max_estimated_execution_time in SettingsChangesHistory#59104
Avogar merged 2 commits intomasterfrom
Avogar-patch-1

Conversation

@Avogar
Copy link
Member

@Avogar Avogar commented Jan 23, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fixes #58402 (comment)

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 23, 2024
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented Jan 23, 2024 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit 415589d with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker server and keeper imagesThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Docs checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending

@Algunenano Algunenano self-assigned this Jan 23, 2024
Algunenano
Algunenano approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@Algunenano Algunenano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. I was about to revert the PR 😄

@Avogar
Copy link
Member Author

Avogar commented Jan 23, 2024

Builds are ok, let's merge

@Avogar Avogar merged commit b8d2af9 into master Jan 23, 2024
@Avogar Avogar deleted the Avogar-patch-1 branch January 23, 2024 11:05
@jsc0218
Copy link
Contributor

jsc0218 commented Jan 23, 2024

thanks for the fix, it was from one I reviewed.

@jsc0218 jsc0218 mentioned this pull request Jan 23, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano approved these changes

Assignees

@Algunenano Algunenano

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Avogar @robot-ch-test-poll2 @jsc0218 @Algunenano