Primary key, MergeTreeIndexFullText and MergeTreeIndexSet support for string functions#5965
Merged
alexey-milovidov merged 6 commits intoClickHouse:masterfrom Jul 16, 2019
dimarub2000:master
Merged
Primary key, MergeTreeIndexFullText and MergeTreeIndexSet support for string functions#5965alexey-milovidov merged 6 commits intoClickHouse:masterfrom dimarub2000:master
alexey-milovidov merged 6 commits intoClickHouse:masterfrom
dimarub2000:master
Conversation
dimarub2000
added
can be tested
and removed
do not test
dimarub2000
changed the title
dimarub2000
changed the title
Contributor
Author
|
I have a test for primary key as well, should I add it after checks are completed? |
| } | ||
| }, | ||
| { | ||
| "startsWith", |
Member
There was a problem hiding this comment.
Let's unify equals, startsWith, endsWith with static free function.
| { | ||
| out.function = RPNElement::FUNCTION_MULTI_SEARCH; | ||
|
|
||
| std::vector<std::vector<BloomFilter>> bloom_filters; |
Member
There was a problem hiding this comment.
Don't understand, why we need 2d array?
Member
There was a problem hiding this comment.
Ok, it's for FUNCTION_IN, where it can apply for tuples:
(a, b) IN ((a1, b1), (a2, b2)...)
Maybe better to add a comment.
|
|
||
| size_t key_arg_pos; /// Position of argument with key column (non-const argument) | ||
| size_t key_column_num = -1; /// Number of a key column (inside key_column_names array) | ||
| std::string func_name = func->name; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
Added support startsWith, endsWith, multiSearchAny, notLike for MergeTreeIndexFullText.
Added support startsWith, endsWith, multiSearchAny for MergeTreeIndexSet.
Added support empty, notEmpty, notLike for Primary key.