Skip to content

Split CastOverloadResolver translation unit#61114

Merged
alexey-milovidov merged 76 commits intomasterfrom
split-cast-overload-resolver
Mar 17, 2024
Merged

Split CastOverloadResolver translation unit#61114
alexey-milovidov merged 76 commits intomasterfrom
split-cast-overload-resolver

Conversation

@alexey-milovidov
Copy link
Member

@alexey-milovidov alexey-milovidov commented Mar 9, 2024 •
edited
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add the function toUInt128OrZero, which was missed by mistake (the mistake is related to #945). The compatibility aliases FROM_UNIXTIME and DATE_FORMAT (they are not ClickHouse-native and only exist for MySQL compatibility) have been made case insensitive, as expected for SQL-compatibility aliases.

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 9, 2024
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented Mar 9, 2024 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit 994bf87 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@alexey-milovidov alexey-milovidov marked this pull request as draft March 9, 2024 05:06
@alexey-milovidov alexey-milovidov marked this pull request as ready for review March 9, 2024 06:59
@azat azat mentioned this pull request Mar 9, 2024
Merged
@alexey-milovidov alexey-milovidov mentioned this pull request Mar 10, 2024
Closed
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-improvement Pull request with some product improvements and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Mar 16, 2024
@alexey-milovidov alexey-milovidov merged commit 677f2da into master Mar 17, 2024
@alexey-milovidov alexey-milovidov deleted the split-cast-overload-resolver branch March 17, 2024 16:16
@alexey-milovidov alexey-milovidov self-assigned this Mar 17, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 17, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Mar 18, 2024
@baibaichen
fix build due to ClickHouse/ClickHouse#61114
8d222a5 
(cherry picked from commit 38b67230de75362e9f6a3ce9c33c2782c19f6add)
baibaichen added a commit to Kyligence/gluten that referenced this pull request Mar 18, 2024
@baibaichen
[Tmp] Remove them for fixing build due to ClickHouse/ClickHouse#61114
eceb17b 
(cherry picked from commit cda35198d988940923061518ea2215b466e7eb0b)
@antonio2368
Copy link
Member

antonio2368 commented Mar 18, 2024

Tidy build fails because of these changes

@antonio2368 antonio2368 mentioned this pull request Mar 18, 2024
Merged
1 task
baibaichen added a commit to Kyligence/gluten that referenced this pull request Mar 18, 2024
@baibaichen
fix build due to ClickHouse/ClickHouse#61114
037df96
baibaichen added a commit to Kyligence/gluten that referenced this pull request Mar 19, 2024
@baibaichen
fix build due to ClickHouse/ClickHouse#61114
a0dec7d 
(cherry picked from commit 037df96)
baibaichen added a commit to apache/gluten that referenced this pull request Mar 19, 2024
@lwz9103 @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20240319) (#5008)
bc08fdf 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240319)

1 fix build due to ClickHouse/ClickHouse#61502
2 fix build due to ClickHouse/ClickHouse#61114
3 fix build due to ClickHouse/ClickHouse#61267

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
@tavplubix tavplubix mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexey-milovidov @robot-ch-test-poll3 @antonio2368 @robot-clickhouse-ci-2