Skip to content

Fix bugfix check (due to "unknown object storage type: azure")#61363

Merged
Algunenano merged 1 commit intoClickHouse:masterfrom
azat:ci/fix-upgrade-bugfix
Mar 19, 2024
Merged

Fix bugfix check (due to "unknown object storage type: azure")#61363
Algunenano merged 1 commit intoClickHouse:masterfrom
azat:ci/fix-upgrade-bugfix

Conversation

@azat
Copy link
Member

@azat azat commented Mar 14, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Follow-up for: #60165 (cc @kssenii )

@azat azat mentioned this pull request Mar 14, 2024
Merged
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 14, 2024
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented Mar 14, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit 02ae7e5 with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending

@kssenii kssenii self-assigned this Mar 14, 2024
@kssenii
Copy link
Member

kssenii commented Mar 14, 2024

Strange, why this https://github.com/ClickHouse/ClickHouse/blob/65f7cd0e0c29cd2cef55665d566ccb8fe82bce33/docker/test/upgrade/run.sh#L83-L86 does not work?

@azat
Copy link
Member Author

azat commented Mar 14, 2024

Hm, haven't seen this, actually it likely works, but the problem is that it does not fix the bugfix check, only upgrade

@azat azat force-pushed the ci/fix-upgrade-bugfix branch from 65f7cd0 to 02ae7e5 Compare March 14, 2024 13:57
@azat
Copy link
Member Author

azat commented Mar 14, 2024

@kssenii I've rebased the patch to fix in the same as you initially did for upgrade.

@azat azat changed the title Fix bugfix/upgrade check (due to "unknown object storage type: azure") Fix bugfix check (due to "unknown object storage type: azure") Mar 14, 2024
@azat azat mentioned this pull request Mar 14, 2024
Closed
@antaljanosbenjamin antaljanosbenjamin mentioned this pull request Mar 19, 2024
Merged
1 task
@Algunenano Algunenano merged commit 8f318be into ClickHouse:master Mar 19, 2024
@azat azat deleted the ci/fix-upgrade-bugfix branch March 19, 2024 11:00
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 19, 2024
@Felixoid Felixoid mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@azat @robot-ch-test-poll3 @kssenii @Algunenano @robot-clickhouse-ci-2