Skip to content

Analyzer: fix group_by_use_nulls#61717

Merged
novikd merged 2 commits intomasterfrom
analyzer-fix-group-by-usel-nulls
Mar 22, 2024
Merged

Analyzer: fix group_by_use_nulls#61717
novikd merged 2 commits intomasterfrom
analyzer-fix-group-by-usel-nulls

Conversation

@novikd
Copy link
Member

@novikd novikd commented Mar 21, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Closes #61697. Follow up for #59986.

@novikd novikd added the analyzer Issues and pull-requests related to new analyzer label Mar 21, 2024
@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 21, 2024
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Mar 21, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit 110b08f with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@antonio2368 antonio2368 self-assigned this Mar 21, 2024
@novikd novikd merged commit 22b26a3 into master Mar 22, 2024
@novikd novikd deleted the analyzer-fix-group-by-usel-nulls branch March 22, 2024 12:17
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 22, 2024
@antonio2368 antonio2368 mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonio2368 antonio2368 antonio2368 approved these changes

Assignees

@antonio2368 antonio2368

Labels

analyzer Issues and pull-requests related to new analyzer pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(Analyzer: this feature is not ready, hold tight) WITH CUBE crashes with group_by_use_nulls

4 participants

@novikd @robot-ch-test-poll @antonio2368 @robot-ch-test-poll1