Skip to content

Fix "invalid escape sequence" in clickhouse-test#63073

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:tests/fix-logs-stats
Apr 29, 2024
Merged

Fix "invalid escape sequence" in clickhouse-test#63073
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
azat:tests/fix-logs-stats

Conversation

@azat
Copy link
Member

@azat azat commented Apr 27, 2024

python error:

/src/ch/clickhouse/.cmake/../tests/clickhouse-test:2570: SyntaxWarning: invalid escape sequence '\/'

And also remove unnecessary escaping of /.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Cc: @tavplubix

@azat
Fix "invalid escape sequence" in clickhouse-test
881e45b 
python error:

    /src/ch/clickhouse/.cmake/../tests/clickhouse-test:2570: SyntaxWarning: invalid escape sequence '\/'

And also remove unnecessary escaping of `/`.

Signed-off-by: Azat Khuzhin <[email protected]>
@azat azat mentioned this pull request Apr 27, 2024
Merged
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 27, 2024
@robot-clickhouse
Copy link
Member

robot-clickhouse commented Apr 27, 2024 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit 881e45b with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@alexey-milovidov alexey-milovidov self-assigned this Apr 27, 2024
@alexey-milovidov
Copy link
Member

alexey-milovidov commented Apr 28, 2024

@azat tests have failed.

@azat
Copy link
Member Author

azat commented Apr 29, 2024 •
edited
Loading

@alexey-milovidov those are not related.

Timedout:

  • 00626_replace_partition_from_table_zookeeper
  • 00906_low_cardinality_cache
  • 00900_long_parquet
  • 00719_parallel_ddl_table

I can do a rebase but not sure that it worth it, this should be a pretty trivial change.

@alexey-milovidov alexey-milovidov merged commit a86f2aa into ClickHouse:master Apr 29, 2024
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 29, 2024
@azat azat deleted the tests/fix-logs-stats branch April 30, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azat @robot-clickhouse @alexey-milovidov