Skip to content

Local plan for parallel replicas#64448

Merged
devcrafter merged 174 commits intomasterfrom
pr-local-plan
Sep 11, 2024
Merged

Local plan for parallel replicas#64448
devcrafter merged 174 commits intomasterfrom
pr-local-plan

Conversation

@devcrafter
Copy link
Member

@devcrafter devcrafter commented May 27, 2024 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

  • Allow: Integration Tests
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Unit tests
  • Allow: Performance tests
  • Allow: All with aarch64
  • Allow: All with ASAN
  • Allow: All with TSAN
  • Allow: All with Analyzer
  • Allow: All with Azure
  • Allow: Add your option here
  • Exclude: Fast test
  • Exclude: Integration Tests
  • Exclude: Stateless tests
  • Exclude: Stateful tests
  • Exclude: Performance tests
  • Exclude: All with ASAN
  • Exclude: All with TSAN
  • Exclude: All with MSAN
  • Exclude: All with UBSAN
  • Exclude: All with Coverage
  • Exclude: All with Aarch64
  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)
  • allow: batch 1 for multi-batch jobs
  • allow: batch 2
  • allow: batch 3
  • allow: batch 4, 5 and 6

@devcrafter devcrafter marked this pull request as draft May 27, 2024 12:25
@devcrafter devcrafter changed the base branch from pr-plan-rewrite to master May 27, 2024 16:01
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 28, 2024
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented May 28, 2024 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit c53e165 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@nickitat nickitat linked an issue May 28, 2024 that may be closed by this pull request
Build full-fledged plan for local replica #63550
Closed
@alexey-milovidov alexey-milovidov changed the title Pr local plan A local plan for parallel replicas May 31, 2024
@devcrafter devcrafter changed the title A local plan for parallel replicas WIP: a local plan for parallel replicas Jun 4, 2024
@devcrafter devcrafter marked this pull request as ready for review June 4, 2024 15:18
@devcrafter
Copy link
Member Author

devcrafter commented Sep 4, 2024 •
edited
Loading

AST Fuzzer failure - Logical error: 'Not-ready Set is passed as the second argument for function 'in''.

UPD: fixed by #69264

Performance comparison errors - afais, they are caused by QueryProfiler, for example (writeTraceInfo() is called only from QueryProfiler):
Screenshot 2024-09-04 at 13 37 57

@devcrafter
Copy link
Member Author

devcrafter commented Sep 5, 2024

Waiting for #69264

@Felixoid Felixoid added this pull request to the merge queue Sep 11, 2024
@devcrafter devcrafter removed this pull request from the merge queue due to a manual request Sep 11, 2024
@devcrafter devcrafter added this pull request to the merge queue Sep 11, 2024
Merged via the queue into master with commit 56b39c3 Sep 11, 2024
@devcrafter devcrafter deleted the pr-local-plan branch September 11, 2024 21:21
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 11, 2024
@devcrafter devcrafter mentioned this pull request Oct 22, 2024
Closed
zoomxi
zoomxi reviewed Dec 6, 2024
View reviewed changes
src/Interpreters/ClusterProxy/executeQuery.cpp
executeQueryWithParallelReplicasCustomKey(query_plan, storage_id, query_info, columns, snapshot, processed_stage, header, context);
}

bool canUseParallelReplicasOnInitiator(const ContextPtr & context)
Copy link
Contributor

@zoomxi zoomxi Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could I kindly inquire about a matter? Why make a new function here to check if a cluster (shard) has only one node, rather than within the Context::canUseParallelReplicasOnInitiator()? If a cluster (shard) has only one node, all ParallelReplicas scenarios need to fall back to local execution, not just in buildQueryPlanForTableExpression(). @devcrafter Looking forward to your reply.

Copy link
Member Author

@devcrafter devcrafter Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zoomxi, it makes sense. If you're up to it, please feel free to provide a PR. Probably, a couple of requirements for such a case, - there should be (1) a warning in traces about fallback to local execution, and (2) a test to check this behavior.

Copy link
Contributor

@zoomxi zoomxi Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks for your reply. @devcrafter

zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 17, 2024
@devcrafter @zvonand
Merge pull request ClickHouse#64448 from ClickHouse/pr-local-plan
b48e249 
Local plan for parallel replicas
@zvonand zvonand mentioned this pull request Dec 19, 2024
Merged
Enmk pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 22, 2024
@devcrafter @Enmk
Merge pull request ClickHouse#64448 from ClickHouse/pr-local-plan
14e8bd2 
Local plan for parallel replicas
This was referenced Jan 24, 2025
Merged
Merged
This was referenced Feb 18, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KochetovNicolai KochetovNicolai KochetovNicolai approved these changes

@nickitat nickitat nickitat approved these changes

+1 more reviewer

@zoomxi zoomxi zoomxi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nickitat nickitat

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build full-fledged plan for local replica

6 participants

@devcrafter @robot-clickhouse-ci-2 @KochetovNicolai @nickitat @zoomxi @robot-ch-test-poll