Skip to content

Improved getting of alter conversions for queries#65832

Merged
CurtizJ merged 17 commits intoClickHouse:masterfrom
CurtizJ:add-mutations-snapshot
Sep 5, 2024
Merged

Improved getting of alter conversions for queries#65832
CurtizJ merged 17 commits intoClickHouse:masterfrom
CurtizJ:add-mutations-snapshot

Conversation

@CurtizJ
Copy link
Member

@CurtizJ CurtizJ commented Jun 28, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 28, 2024
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Jun 28, 2024 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit 6042637 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@CurtizJ CurtizJ force-pushed the add-mutations-snapshot branch from 8a50fbd to 096616b Compare June 28, 2024 22:28
@CurtizJ CurtizJ marked this pull request as ready for review July 8, 2024 19:29
@CurtizJ CurtizJ force-pushed the add-mutations-snapshot branch from 261a73c to 2df3e99 Compare July 19, 2024 17:26
@CurtizJ CurtizJ requested a review from alesapin August 7, 2024 09:19
@alesapin alesapin self-assigned this Aug 19, 2024
alesapin
alesapin approved these changes Aug 26, 2024
View reviewed changes
src/Storages/MergeTree/MergeTask.cpp
*global_ctx->data,
global_ctx->storage_snapshot,
global_ctx->future_part->parts[part_num],
global_ctx->alter_conversions[part_num],
Copy link
Member

@alesapin alesapin Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe store it inside future_part (just to avoid this indexing)?

Copy link
Member Author

@CurtizJ CurtizJ Sep 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get how it will help to avoid indexing because we need to store a vector of alter conversions anyways. But it will required injecting context and metadata snapshot to FutureMergedMutatedPart which may be inconvenient in some places.

@CurtizJ CurtizJ force-pushed the add-mutations-snapshot branch from b882c51 to 70fba65 Compare September 4, 2024 08:54
@CurtizJ CurtizJ force-pushed the add-mutations-snapshot branch from 70fba65 to 6042637 Compare September 4, 2024 11:36
@CurtizJ CurtizJ added this pull request to the merge queue Sep 5, 2024
Merged via the queue into ClickHouse:master with commit cf022d3 Sep 5, 2024
@CurtizJ CurtizJ deleted the add-mutations-snapshot branch September 5, 2024 11:16
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 5, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Sep 6, 2024
@baibaichen
Fix build due to ClickHouse/ClickHouse#65832
54e825f
baibaichen added a commit to Kyligence/gluten that referenced this pull request Sep 6, 2024
@baibaichen
Fix build due to ClickHouse/ClickHouse#65832
e0656b7
baibaichen added a commit to Kyligence/gluten that referenced this pull request Sep 6, 2024
@baibaichen
Fix UT due to ClickHouse/ClickHouse#65832
1bdebdc
baibaichen added a commit to Kyligence/gluten that referenced this pull request Sep 6, 2024
@baibaichen
Fix build due to ClickHouse/ClickHouse#65832
1da0e63
baibaichen added a commit to Kyligence/gluten that referenced this pull request Sep 6, 2024
@baibaichen
Fix UT due to ClickHouse/ClickHouse#65832
3e9ea59
baibaichen added a commit to Kyligence/gluten that referenced this pull request Sep 6, 2024
@baibaichen
Fix build due to ClickHouse/ClickHouse#65832
e870360
baibaichen added a commit to Kyligence/gluten that referenced this pull request Sep 6, 2024
@baibaichen
Fix UT due to ClickHouse/ClickHouse#65832
029745e
baibaichen added a commit to Kyligence/gluten that referenced this pull request Sep 6, 2024
@baibaichen
Fix UT due to ClickHouse/ClickHouse#65832
7455205
baibaichen added a commit to apache/gluten that referenced this pull request Sep 6, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20240906) (#7137)
c93649d 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240906)

* Fix build due to ClickHouse/ClickHouse#65832

* Fix UT due to ClickHouse/ClickHouse#65832

* Fix conflict with #7122

* Fix conflict with #7029

* Run GlutenClickHouseMergeTreeCacheDataSSuite locally

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
dcoliversun pushed a commit to dcoliversun/gluten that referenced this pull request Sep 11, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20240906) (apache#7137
23d7b6f 
)

* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240906)

* Fix build due to ClickHouse/ClickHouse#65832

* Fix UT due to ClickHouse/ClickHouse#65832

* Fix conflict with apache#7122

* Fix conflict with apache#7029

* Run GlutenClickHouseMergeTreeCacheDataSSuite locally

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20240906) (apache#7137
655dda8 
)

* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240906)

* Fix build due to ClickHouse/ClickHouse#65832

* Fix UT due to ClickHouse/ClickHouse#65832

* Fix conflict with apache#7122

* Fix conflict with apache#7029

* Run GlutenClickHouseMergeTreeCacheDataSSuite locally

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
@lzydmxy
Copy link
Contributor

lzydmxy commented Dec 3, 2024

@CurtizJ Hi, if it would be possible to merge the pr into the v24.3 branch.

I'm currently experiencing a performance issue related to lock contention with currently_processing_in_background_mutex when handling 100 concurrent requests involving 4000 parts. This contention significantly impacts the performance of our application.

flameGraph about it
flame_CPU_after

@lzydmxy lzydmxy mentioned this pull request Dec 4, 2024
Closed
@lzydmxy
Copy link
Contributor

lzydmxy commented Dec 6, 2024

Hi @CurtizJ

I hope you're doing well. I wanted to follow up on my previous message. When you have a moment, could you please take a look? Your input would be greatly appreciated.

Thank you!

zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 18, 2024
@CurtizJ @zvonand
Merge pull request ClickHouse#65832 from CurtizJ/add-mutations-snapshot
9d7b3d7 
Improved getting of alter conversions for queries
@zvonand zvonand mentioned this pull request Dec 19, 2024
Merged
Enmk pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 22, 2024
@CurtizJ @Enmk
Merge pull request ClickHouse#65832 from CurtizJ/add-mutations-snapshot
764d5bb 
Improved getting of alter conversions for queries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alesapin alesapin alesapin approved these changes

Assignees

@alesapin alesapin

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CurtizJ @robot-ch-test-poll1 @lzydmxy @alesapin @robot-ch-test-poll2