DOCAPI-7436: Enum type docs. EN review, RU translation.#6630
Merged
BayoNet merged 5 commits intoClickHouse:masterfrom Aug 26, 2019
Merged
DOCAPI-7436: Enum type docs. EN review, RU translation.#6630BayoNet merged 5 commits intoClickHouse:masterfrom
BayoNet merged 5 commits intoClickHouse:masterfrom
Conversation
BayoNet
added
comp-documentation
BayoNet
changed the title
blinkov
suggested changes
Aug 23, 2019
docs/en/data_types/enum.md
Outdated
| # Enum | ||
|
|
||
| Enumerated type storing pairs of the `'string' = integer` format. | ||
| Enumerated type storing pairs in `'string' = integer` format. |
Contributor
There was a problem hiding this comment.
this sounds confusing since real data is stored only as integers, I'd suggest rewriting it without using "store"
docs/en/data_types/enum.md
Outdated
| - 16-bit `Enum`. It can contain up to 65536 values enumerated in the `[-32768, 32767]` range. | ||
|
|
||
| ClickHouse automatically chooses a type for `Enum` at data insertion. Also, you can use `Enum8` or `Enum16` types to be sure in size of storage. | ||
| ClickHouse automatically chooses the type of `Enum` when data is inserted. You can also use `Enum8` or `Enum16` types to lock in the storage size. |
Contributor
There was a problem hiding this comment.
- second sentence does not make sense now
- needs a link to LowCardinality(String) data type as an alternative more flexible approach
Contributor
Author
There was a problem hiding this comment.
LowCardinality is not described yet, but I added your comment to the task for the type description.
Co-Authored-By: Ivan Blinkov <[email protected]>
Co-Authored-By: Ivan Blinkov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category (leave one):