Split the integration test test_dictionaries into 4 separate tests.#6776
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Sep 2, 2019
Merged
Conversation
vitlibar
force-pushed
the
split-test-dictionaries
branch
from
7b931db to
d64d75e
Compare
alexey-milovidov
approved these changes
Sep 2, 2019
KochetovNicolai
added
the
pr-build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category (leave one):
The integration test
test_dictionariesused to be quite complicated with many fixtures.I've separated this test into four parts, and also renamed tests
test_cached_dictionary_stringandtest_external_dictionariesfor consistency.