Skip to content

Fix 'Refresh set entry already exists'#68249

Merged
al13n321 merged 2 commits intomasterfrom
rset
Aug 13, 2024
Merged

Fix 'Refresh set entry already exists'#68249
al13n321 merged 2 commits intomasterfrom
rset

Conversation

@al13n321
Copy link
Member

@al13n321 al13n321 commented Aug 12, 2024 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

If server crashed in the middle of table drop, on next startup DatabaseCatalog runs a special code path to temporarily (for ~8 minutes by default) attach the table then drop it again. If it's a refreshable materialized view, during this time it was occupying a "RefreshSet" entry, preventing new MVs with the same name from being created.

The problem was that StorageMaterializedView added itself to RefreshSet when the table is created rather than when it's started (startup() is not called on tables temporarily attached for cleanup). This PR fixes it. It also makes RefreshSet allow name collisions in case there are other cases when it can happen.

Tested it manually by killing the server during StorageMaterializedView::drop().

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 12, 2024
@robot-clickhouse-ci-1
Copy link
Contributor

robot-clickhouse-ci-1 commented Aug 12, 2024 •
edited by robot-ch-test-poll3
Loading

This is an automated comment for commit f126094 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@al13n321 al13n321 marked this pull request as ready for review August 12, 2024 19:48
@antonio2368
Copy link
Member

antonio2368 commented Aug 13, 2024

Tested it manually by killing the server during StorageMaterializedView::drop().

This can be an integration test, stop_clickhouse has kill argument

@vdimir vdimir self-assigned this Aug 13, 2024
@al13n321 al13n321 added this pull request to the merge queue Aug 13, 2024
Merged via the queue into master with commit f4b8a98 Aug 13, 2024
@al13n321 al13n321 deleted the rset branch August 13, 2024 20:46
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 13, 2024
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Oct 6, 2025
@al13n321 @zvonand
Merge pull request ClickHouse#68249 from ClickHouse/rset
f9b019d 
Fix 'Refresh set entry already exists'
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Oct 6, 2025
@al13n321 @zvonand
Merge pull request ClickHouse#68249 from ClickHouse/rset
a0a25c5 
Fix 'Refresh set entry already exists'
@zvonand zvonand mentioned this pull request Oct 6, 2025
Merged
13 tasks
@zvonand zvonand mentioned this pull request Oct 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdimir vdimir vdimir approved these changes

Assignees

@vdimir vdimir

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@al13n321 @robot-clickhouse-ci-1 @antonio2368 @vdimir @robot-clickhouse-ci-2