Add settings output_format_orc_dictionary_key_size_threshold to allow user to enable dict encoding for string column in ORC output format#68591
Merged
Avogar merged 13 commits intoClickHouse:masterfrom Sep 17, 2024
Conversation
Contributor
|
This is an automated comment for commit 4412946 with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
Avogar
reviewed
Aug 21, 2024
Avogar
reviewed
Aug 28, 2024
Avogar
approved these changes
Sep 11, 2024
Merged
21 tasks
Contributor
Author
|
https://s3.amazonaws.com/clickhouse-test-reports/68591/0de3b1dacbc587e7f6789dec3fe92e276f332f56/stateful_tests__ubsan_.html I can't figure out why it failed |
Member
@taiyang-li Please update the PR with recent master. It was an issue in CI, - was fixed by #69483 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add settings
output_format_orc_dictionary_key_size_thresholdto allow user to enable dict encoding for string column in ORC output format. It helps reduce the output orc file size and improve reading performance significantly.TODO
EncodedStringVectorBatchfor interfaceStringColumnWriter::add(in Improve string column dict encoding performance orc#15)Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing):