Skip to content

Fix progress bar when reading from Memory tables#69234

Merged
al13n321 merged 1 commit intomasterfrom
memprog
Sep 4, 2024
Merged

Fix progress bar when reading from Memory tables#69234
al13n321 merged 1 commit intomasterfrom
memprog

Conversation

@al13n321
Copy link
Member

@al13n321 al13n321 commented Sep 3, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Example:

create table m (x Int64) engine Memory;
insert into m select * from numbers(10) settings max_block_size=1;
select sleep(1) from m settings max_block_size=1, max_threads=1; -- this shows progress bar now

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 3, 2024
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented Sep 3, 2024 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit 7caacb7 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@thevar1able thevar1able self-assigned this Sep 3, 2024
@al13n321 al13n321 mentioned this pull request Sep 3, 2024
Merged
19 tasks
@al13n321 al13n321 added this pull request to the merge queue Sep 4, 2024
Merged via the queue into master with commit e6af5d6 Sep 4, 2024
@al13n321 al13n321 deleted the memprog branch September 4, 2024 08:00
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thevar1able thevar1able thevar1able approved these changes

Assignees

@thevar1able thevar1able

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@al13n321 @robot-ch-test-poll2 @thevar1able @robot-clickhouse-ci-1 @robot-clickhouse-ci-2