Skip to content

Fix: Not-ready Set with parallel replicas#69264

Merged
devcrafter merged 7 commits intomasterfrom
fix-pr-not-ready-set
Sep 6, 2024
Merged

Fix: Not-ready Set with parallel replicas#69264
devcrafter merged 7 commits intomasterfrom
fix-pr-not-ready-set

Conversation

@devcrafter
Copy link
Member

@devcrafter devcrafter commented Sep 4, 2024

The error happened during estimation of number of rows to read for parallel replicas, i.e. with non-zero parallel_replicas_min_number_of_rows_per_replica, and queries with IN operator in condition

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 4, 2024
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Sep 4, 2024 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit b3b8abb with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@KochetovNicolai KochetovNicolai added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Sep 4, 2024
@KochetovNicolai KochetovNicolai self-assigned this Sep 4, 2024
@devcrafter devcrafter mentioned this pull request Sep 4, 2024
Merged
29 tasks
@devcrafter devcrafter added this pull request to the merge queue Sep 5, 2024
@devcrafter devcrafter removed this pull request from the merge queue due to a manual request Sep 5, 2024
nikitamikhaylov
nikitamikhaylov reviewed Sep 6, 2024
View reviewed changes
tests/ci/ci_config.py
required_builds=[BuildNames.PACKAGE_TSAN], num_batches=6
required_builds=[BuildNames.PACKAGE_TSAN],
num_batches=6,
timeout=9000, # the job timed out with default value (7200)
Copy link
Member

@nikitamikhaylov nikitamikhaylov Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed by #69322 and #69324

@devcrafter devcrafter enabled auto-merge September 6, 2024 18:47
@devcrafter devcrafter added this pull request to the merge queue Sep 6, 2024
Merged via the queue into master with commit fe5c0e1 Sep 6, 2024
@devcrafter devcrafter deleted the fix-pr-not-ready-set branch September 6, 2024 19:21
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 6, 2024
This was referenced Sep 6, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Sep 6, 2024
@robot-clickhouse
Backport #69264 to 24.6: Fix: Not-ready Set with parallel replicas
f410762
This was referenced Sep 6, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Sep 6, 2024
@robot-clickhouse
Backport #69264 to 24.7: Fix: Not-ready Set with parallel replicas
5392af6
This was referenced Sep 6, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Sep 6, 2024
@robot-clickhouse
Backport #69264 to 24.8: Fix: Not-ready Set with parallel replicas
a163571
@robot-clickhouse robot-clickhouse mentioned this pull request Sep 6, 2024
Merged
robot-ch-test-poll4 added a commit that referenced this pull request Sep 6, 2024
@robot-ch-test-poll4
Merge pull request #69349 from ClickHouse/backport/24.6/69264
868ae45 
Backport #69264 to 24.6: Fix: Not-ready Set with parallel replicas
robot-ch-test-poll added a commit that referenced this pull request Sep 6, 2024
@robot-ch-test-poll
Merge pull request #69351 from ClickHouse/backport/24.7/69264
3871a14 
Backport #69264 to 24.7: Fix: Not-ready Set with parallel replicas
robot-clickhouse-ci-1 added a commit that referenced this pull request Sep 6, 2024
@robot-clickhouse-ci-1
Merge pull request #69353 from ClickHouse/backport/24.8/69264
348b3ba 
Backport #69264 to 24.8: Fix: Not-ready Set with parallel replicas
robot-clickhouse added a commit that referenced this pull request Sep 10, 2024
@robot-clickhouse
Backport #69264 to 24.3: Fix: Not-ready Set with parallel replicas
d2c910b
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Sep 10, 2024
Merged
@robot-ch-test-poll1 robot-ch-test-poll1 added pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP labels Sep 10, 2024
devcrafter added a commit that referenced this pull request Sep 10, 2024
@devcrafter
Merge pull request #69421 from ClickHouse/backport/24.3/69264
996fa9a 
Backport #69264 to 24.3: Fix: Not-ready Set with parallel replicas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikitamikhaylov nikitamikhaylov nikitamikhaylov left review comments

@KochetovNicolai KochetovNicolai KochetovNicolai approved these changes

Assignees

@KochetovNicolai KochetovNicolai

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@devcrafter @robot-ch-test-poll1 @KochetovNicolai @nikitamikhaylov @robot-ch-test-poll @robot-ch-test-poll3 @robot-clickhouse