Allow reading LowCardinality(String/FixedString) data from orc dictionary encoded columns#69481
Merged
alexey-milovidov merged 25 commits intoClickHouse:masterfrom Oct 15, 2024
Merged
Conversation
Contributor
|
This is an automated comment for commit 8cbaec9 with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
Contributor
Author
|
@nickitat hope for your reviews, thanks! |
fuwhu
reviewed
Oct 14, 2024
alexey-milovidov
approved these changes
Oct 15, 2024
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
Oct 16, 2024
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
Oct 16, 2024
baibaichen
added a commit
to apache/gluten
that referenced
this pull request
Oct 16, 2024
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20241016) * Fix Build due to ClickHouse/ClickHouse#70158 * Fix build due to ClickHouse/ClickHouse#62966 * add more info for exception * Fix ut due to ClickHouse/ClickHouse#69481 --------- Co-authored-by: kyligence-git <[email protected]> Co-authored-by: Chang Chen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Enable reading LowCardinality string columns from ORC.
This PR must be reviewed after #68591
1 Construct the data
2 Readind dict.orc and execute group by (speedup 2.6x)
Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing):