Skip to content

Remove explicit announce from local replica in ReadFromMergeTree#69602

Merged
nickitat merged 4 commits intomasterfrom
rm_explicit_initial_announce_from_RFMT
Sep 14, 2024
Merged

Remove explicit announce from local replica in ReadFromMergeTree#69602
nickitat merged 4 commits intomasterfrom
rm_explicit_initial_announce_from_RFMT

Conversation

@nickitat
Copy link
Member

@nickitat nickitat commented Sep 13, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@nickitat nickitat requested a review from devcrafter September 13, 2024 16:03
@nickitat nickitat mentioned this pull request Sep 13, 2024
Merged
20 tasks
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 13, 2024
@robot-clickhouse
Copy link
Member

robot-clickhouse commented Sep 13, 2024 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit 8fd9345 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

devcrafter
devcrafter approved these changes Sep 13, 2024
View reviewed changes
@nickitat
Copy link
Member Author

nickitat commented Sep 14, 2024

Stress test (debug) - #69573

@nickitat nickitat added this pull request to the merge queue Sep 14, 2024
Merged via the queue into master with commit 918ead0 Sep 14, 2024
@nickitat nickitat deleted the rm_explicit_initial_announce_from_RFMT branch September 14, 2024 18:15
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 14, 2024
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 13, 2024
@nickitat @zvonand
Merge pull request ClickHouse#69602 from ClickHouse/rm_explicit_initi…
1596594 
…al_announce_from_RFMT

Remove explicit announce from local replica in ReadFromMergeTree
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 17, 2024
@nickitat @zvonand
Merge pull request ClickHouse#69602 from ClickHouse/rm_explicit_initi…
f1cf4fc 
…al_announce_from_RFMT

Remove explicit announce from local replica in ReadFromMergeTree
@zvonand zvonand mentioned this pull request Dec 19, 2024
Merged
Enmk pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 22, 2024
@nickitat @Enmk
Merge pull request ClickHouse#69602 from ClickHouse/rm_explicit_initi…
049c2f6 
…al_announce_from_RFMT

Remove explicit announce from local replica in ReadFromMergeTree
This was referenced Jan 24, 2025
Merged
Merged
This was referenced Feb 18, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devcrafter devcrafter devcrafter approved these changes

Assignees

@devcrafter devcrafter

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nickitat @robot-clickhouse @devcrafter @robot-ch-test-poll3 @robot-clickhouse-ci-2