New profile events for parallel replicas#69706
Merged
Conversation
robot-ch-test-poll3
added
the
pr-not-for-changelog
Contributor
|
This is an automated comment for commit 4e76a2b with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
kssenii
approved these changes
Sep 18, 2024
src/Common/ProfileEvents.cpp
Outdated
| M(ParallelReplicasHandleRequestMicroseconds, "Time spent processing requests for marks from replicas") \ | ||
| M(ParallelReplicasHandleAnnouncementMicroseconds, "Time spent processing replicas announcements") \ | ||
| M(ParallelReplicasAnnouncementMicroseconds, "Time spent to send an announcement") \ | ||
| M(ParallelReplicasReadRequestMicroseconds, "Time spent for a read requests") \ |
Member
There was a problem hiding this comment.
Suggested change
| M(ParallelReplicasReadRequestMicroseconds, "Time spent for a read requests") \ | |
| M(ParallelReplicasReadRequestMicroseconds, "Time spent for read requests") \ |
Comment on lines
+47
to
+48
| size_t number_of_current_replica; | ||
| size_t total_nodes_count; |
Member
There was a problem hiding this comment.
Suggested change
| size_t number_of_current_replica; | |
| size_t total_nodes_count; | |
| const size_t number_of_current_replica; | |
| const size_t total_nodes_count; |
| auto operator()(Args &&... args) | ||
| { | ||
| DB::OpenTelemetry::SpanHolder span(span_name); | ||
| DB::ProfileEventTimeIncrement<DB::Time::Microseconds> increment(event); |
Member
There was a problem hiding this comment.
btw we do have two ways to do the same thing: ProfileEventTimeIncrement and ProfileEvent::Timer (looks like auto timer = DB::CurrentThread::getProfileEvents().timer(event);). Should we delete one of them? Just contemplating, not asking you to do anything
Member
Author
There was a problem hiding this comment.
never saw this one. will try to remove it
Member
Author
|
during testing found #69744 |
robot-ch-test-poll2
added
the
pr-synced-to-cloud
zvonand
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Dec 17, 2024
New profile events for parallel replicas
Enmk
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Dec 22, 2024
New profile events for parallel replicas
This was referenced Jan 24, 2025
This was referenced Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):