Skip to content

Remove QueryPlan DataStream.#70158

Merged
KochetovNicolai merged 10 commits intomasterfrom
remove-plan-streams
Oct 15, 2024
Merged

Remove QueryPlan DataStream.#70158
KochetovNicolai merged 10 commits intomasterfrom
remove-plan-streams

Conversation

@KochetovNicolai
Copy link
Member

@KochetovNicolai KochetovNicolai commented Oct 1, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Continuation of #68410

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 1, 2024
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Oct 1, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit 380d55b with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@novikd novikd self-assigned this Oct 1, 2024
novikd
novikd reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@novikd novikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM

@KochetovNicolai KochetovNicolai added this pull request to the merge queue Oct 15, 2024
Merged via the queue into master with commit 96b9f4a Oct 15, 2024
@KochetovNicolai KochetovNicolai deleted the remove-plan-streams branch October 15, 2024 16:05
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Oct 15, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Oct 16, 2024
@baibaichen
Fix Build due to ClickHouse/ClickHouse#70158
774cd54
baibaichen added a commit to Kyligence/gluten that referenced this pull request Oct 16, 2024
@baibaichen
Fix Build due to ClickHouse/ClickHouse#70158
ea6fda5
baibaichen added a commit to apache/gluten that referenced this pull request Oct 16, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20241016) (#7558)
29375d1 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20241016)

* Fix Build due to ClickHouse/ClickHouse#70158

* Fix build due to ClickHouse/ClickHouse#62966

* add more info for exception

* Fix ut due to ClickHouse/ClickHouse#69481

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@novikd novikd novikd left review comments

Assignees

@novikd novikd

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KochetovNicolai @robot-ch-test-poll @novikd @robot-ch-test-poll2 @robot-clickhouse-ci-1