Fix negate function monotonicity#71440
Merged
nikitamikhaylov merged 15 commits intomasterfrom Feb 19, 2025
Merged
Conversation
30 tasks
Member
|
This is an automated comment for commit 83720a8 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
evillique
approved these changes
Nov 5, 2024
Member
|
@evillique, please update the test. |
Member
Author
|
The remaining test failures look unrelated. |
Member
Author
|
Fixed one of them: #72870 |
Member
Author
|
I somehow still don't know what's the intended way to deal with flaky tests blocking PRs ~100% of the time. Will keep merging origin/master into every PR every few days until CI passes by chance. |
Member
|
Fix all the tests. |
Contributor
|
Dear @evillique, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix negate function monotonicity. In previous versions, the query
select * from a where -x = -42;wherexis the primary key, can return a wrong result.Fixes this:
It used to return empty result because KeyCondition took the range [42, 12345678901234567890], asked function
negatewhether it's monotonic on this range, it (incorrectly) said yes, and KeyCondition appliednegateto this range, producing an inverted range [6101065172474983726, -42] (where 6101065172474983726 is what -12345678901234567890 overflows to).