Skip to content

Read AWS EKS token from file, attempt #2#72397

Merged
thevar1able merged 1 commit intomasterfrom
fix-aws-ecs-container-env-var-name
Nov 25, 2024
Merged

Read AWS EKS token from file, attempt #2#72397
thevar1able merged 1 commit intomasterfrom
fix-aws-ecs-container-env-var-name

Conversation

@thevar1able
Copy link
Member

@thevar1able thevar1able commented Nov 25, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Use AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE instead of AWS_CONTAINER_AUTHORIZATION_TOKEN_PATH. Fixes #71074

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Nov 25, 2024
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Nov 25, 2024 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit 69b4743 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@evillique evillique self-assigned this Nov 25, 2024
@evillique
Copy link
Member

evillique commented Nov 25, 2024

I think we should also backport it

@thevar1able thevar1able added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Nov 25, 2024
@thevar1able thevar1able added this pull request to the merge queue Nov 25, 2024
Merged via the queue into master with commit 7c3d015 Nov 25, 2024
@thevar1able thevar1able deleted the fix-aws-ecs-container-env-var-name branch November 25, 2024 17:26
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 25, 2024
This was referenced Nov 25, 2024
Closed
Closed
Closed
Closed
Merged
robot-ch-test-poll added a commit that referenced this pull request Nov 25, 2024
@robot-ch-test-poll
Merge pull request #72419 from ClickHouse/cherrypick/24.11/72397
8986ef3 
Cherry pick #72397 to 24.11: Read AWS EKS token from file, attempt #2
robot-clickhouse added a commit that referenced this pull request Nov 25, 2024
@robot-clickhouse
Backport #72397 to 24.11: Read AWS EKS token from file, attempt #2
b039521
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Nov 25, 2024
Merged
thevar1able added a commit that referenced this pull request Nov 25, 2024
@thevar1able
Merge pull request #72420 from ClickHouse/backport/24.11/72397
be86397 
Backport #72397 to 24.11: Read AWS EKS token from file, attempt #2
@robot-ch-test-poll robot-ch-test-poll added pr-backports-created-cloud deprecated label, NOOP pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore labels Nov 25, 2024
@thevar1able thevar1able mentioned this pull request Jun 23, 2025
Merged
@yokofly yokofly mentioned this pull request Oct 16, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evillique evillique evillique approved these changes

Assignees

@evillique evillique

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AWS Credentials should support AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE.

6 participants

@thevar1able @robot-ch-test-poll1 @evillique @robot-clickhouse @robot-ch-test-poll @robot-clickhouse-ci-2