Skip to content

Fix exception in RemoteQueryExecutor when user does not exist locally#72759

Merged
yariks5s merged 5 commits intoClickHouse:masterfrom
zvonand:hotfix-72756
Dec 6, 2024
Merged

Fix exception in RemoteQueryExecutor when user does not exist locally#72759
yariks5s merged 5 commits intoClickHouse:masterfrom
zvonand:hotfix-72756

Conversation

@zvonand
Copy link
Contributor

@zvonand zvonand commented Dec 3, 2024

Closes #72756

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix exception thrown in RemoteQueryExecutor when user does not exist locally

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@zvonand zvonand marked this pull request as ready for review December 3, 2024 18:59
@zvonand
Copy link
Contributor Author

zvonand commented Dec 3, 2024

@Algunenano could you please put a can-be-tested here?

@yariks5s yariks5s self-assigned this Dec 3, 2024
@yariks5s yariks5s added the can be tested Allows running workflows for external contributors label Dec 3, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-bugfix Pull request with bugfix, not backported by default label Dec 3, 2024
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Dec 3, 2024 •
edited
Loading

This is an automated comment for commit 9b0f33b with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch❌ error
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@pufit
Copy link
Member

pufit commented Dec 4, 2024

Please add a test that reproduces the error

@zvonand
Copy link
Contributor Author

zvonand commented Dec 5, 2024 •
edited
Loading

@yariks5s do you by any chance know what is bugfix validation and why it is failing? it does not like the tests are the issue:

_____________ ERROR at setup of test_push_role_to_other_nodes[4-5] _____________
[gw0] linux -- Python 3.10.12 /usr/bin/python3

    @pytest.fixture(scope="module", autouse=True)
    def ldap_cluster():
        try:
>           cluster.start()

test_ldap_external_user_directory/test.py:34:

It is failing at start-up, while the same tests work perfectly in all integration tests iterations

Is this situation OK?

@yariks5s
Copy link
Member

yariks5s commented Dec 6, 2024

This situation seems not ok, but I don't know the root cause yet, will try to dig it up more

@yariks5s
Copy link
Member

yariks5s commented Dec 6, 2024

I see similar errors in other PRs that were ignored, let's do the same :)

@yariks5s yariks5s added this pull request to the merge queue Dec 6, 2024
Merged via the queue into ClickHouse:master with commit d522f3f Dec 6, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Dec 6, 2024
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Dec 6, 2024
@robot-ch-test-poll3
Merge pull request #72902 from ClickHouse/cherrypick/24.11/72759
ed43d9f 
Cherry pick #72759 to 24.11: Fix #72756 (exception in RemoteQueryExecutor when user does not exist locally)
robot-clickhouse added a commit that referenced this pull request Dec 6, 2024
@robot-clickhouse
Backport #72759 to 24.11: Fix #72756 (exception in RemoteQueryExecuto…
f6804a8 
…r when user does not exist locally)
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Dec 6, 2024
Merged
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 6, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 6, 2024
yariks5s added a commit that referenced this pull request Dec 6, 2024
@yariks5s
Merge pull request #72903 from ClickHouse/backport/24.11/72759
cd6a9f7 
Backport #72759 to 24.11: Fix #72756 (exception in RemoteQueryExecutor when user does not exist locally)
@zvonand zvonand deleted the hotfix-72756 branch December 7, 2024 01:15
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 7, 2024
@yariks5s @zvonand
Merge pull request ClickHouse#72759 from zvonand/hotfix-72756
254bd1f 
Fix ClickHouse#72756 (exception in RemoteQueryExecutor when user does not exist locally)
@zvonand zvonand changed the title Fix #72756 (exception in RemoteQueryExecutor when user does not exist locally) Fix exception in RemoteQueryExecutor when user does not exist locally Dec 7, 2024
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 13, 2024
@yariks5s @zvonand
Merge pull request ClickHouse#72759 from zvonand/hotfix-72756
36e4c0a 
Fix ClickHouse#72756 (exception in RemoteQueryExecutor when user does not exist locally)
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 17, 2024
@yariks5s @zvonand
Merge pull request ClickHouse#72759 from zvonand/hotfix-72756
d2b3dc0 
Fix ClickHouse#72756 (exception in RemoteQueryExecutor when user does not exist locally)
@zvonand zvonand mentioned this pull request Dec 19, 2024
Merged
Enmk pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 22, 2024
@yariks5s @Enmk
Merge pull request ClickHouse#72759 from zvonand/hotfix-72756
5103af7 
Fix ClickHouse#72756 (exception in RemoteQueryExecutor when user does not exist locally)
@Enmk Enmk mentioned this pull request Jan 21, 2025
Merged
@Enmk Enmk mentioned this pull request Jan 28, 2025
Merged
This was referenced Feb 18, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yariks5s yariks5s yariks5s approved these changes

Assignees

@yariks5s yariks5s

Labels

can be tested Allows running workflows for external contributors pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

secureRemote: There is no user demo in user directories: While executing Remote.

7 participants

@zvonand @robot-clickhouse-ci-2 @pufit @yariks5s @robot-clickhouse @robot-ch-test-poll1 @robot-clickhouse-ci-1