Skip to content

Fix if condition in #63151#73504

Merged
devcrafter merged 4 commits intoClickHouse:masterfrom
zvonand:fix-typo-in-63151
Dec 24, 2024
Merged

Fix if condition in #63151#73504
devcrafter merged 4 commits intoClickHouse:masterfrom
zvonand:fix-typo-in-63151

Conversation

@zvonand
Copy link
Contributor

@zvonand zvonand commented Dec 17, 2024

Fix if that will never be true. #63151 (comment)
Cc @devcrafter

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Dec 18, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 18, 2024
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented Dec 18, 2024 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit 3e1b547 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@devcrafter devcrafter self-assigned this Dec 18, 2024
@devcrafter
Copy link
Member

devcrafter commented Dec 18, 2024

AST fuzzer (debug) — Logical error: 'Block structure mismatch in QueryPipeline stream: different ... - #71217

@zvonand
Copy link
Contributor Author

zvonand commented Dec 19, 2024

No other fails exist

@devcrafter
Copy link
Member

devcrafter commented Dec 19, 2024

No other fails exist

Please update your branch with master

@zvonand
Copy link
Contributor Author

zvonand commented Dec 22, 2024

@devcrafter CI is green

@devcrafter devcrafter added this pull request to the merge queue Dec 24, 2024
Merged via the queue into ClickHouse:master with commit abc6bf9 Dec 24, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 24, 2024
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Dec 24, 2024
Merged
robot-ch-test-poll added a commit that referenced this pull request Dec 24, 2024
@robot-ch-test-poll
Merge pull request #73787 from ClickHouse/cherrypick/24.10/73504
e5be32e 
Cherry pick #73504 to 24.10: Fix if condition in #63151
robot-clickhouse added a commit that referenced this pull request Dec 24, 2024
@robot-clickhouse
Backport #73504 to 24.10: Fix if condition in #63151
d5ab2c2
This was referenced Dec 24, 2024
Merged
Merged
robot-ch-test-poll added a commit that referenced this pull request Dec 24, 2024
@robot-ch-test-poll
Merge pull request #73789 from ClickHouse/cherrypick/24.11/73504
2245ace 
Cherry pick #73504 to 24.11: Fix if condition in #63151
robot-clickhouse added a commit that referenced this pull request Dec 24, 2024
@robot-clickhouse
Backport #73504 to 24.11: Fix if condition in #63151
047d416
This was referenced Dec 24, 2024
Merged
Merged
robot-ch-test-poll added a commit that referenced this pull request Dec 24, 2024
@robot-ch-test-poll
Merge pull request #73791 from ClickHouse/cherrypick/24.12/73504
5711a2f 
Cherry pick #73504 to 24.12: Fix if condition in #63151
robot-clickhouse added a commit that referenced this pull request Dec 24, 2024
@robot-clickhouse
Backport #73504 to 24.12: Fix if condition in #63151
b41fe6f
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Dec 24, 2024
Merged
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created-cloud deprecated label, NOOP label Dec 24, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 24, 2024
robot-clickhouse-ci-2 added a commit that referenced this pull request Dec 24, 2024
@robot-clickhouse-ci-2
Merge pull request #73788 from ClickHouse/backport/24.10/73504
3763a6a 
Backport #73504 to 24.10: Fix if condition in #63151
robot-ch-test-poll2 added a commit that referenced this pull request Dec 24, 2024
@robot-ch-test-poll2
Merge pull request #73790 from ClickHouse/backport/24.11/73504
6f56f33 
Backport #73504 to 24.11: Fix if condition in #63151
devcrafter added a commit that referenced this pull request Jan 5, 2025
@devcrafter
Merge pull request #73792 from ClickHouse/backport/24.12/73504
b610ac2 
Backport #73504 to 24.12: Fix if condition in #63151
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devcrafter devcrafter devcrafter approved these changes

Assignees

@devcrafter devcrafter

Labels

can be tested Allows running workflows for external contributors pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zvonand @robot-ch-test-poll3 @devcrafter @alexey-milovidov @robot-clickhouse @robot-ch-test-poll1