Resolve the issue of leaking keeper watches.#74521
Merged
vdimir merged 4 commits intoClickHouse:masterfrom Jan 22, 2025
Merged
Conversation
Contributor
Author
|
PTAL @vdimir |
05e8b49 to
d6d272a
Compare
d6d272a to
9b1188f
Compare
Contributor
|
This is an automated comment for commit e264eca with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
Contributor
Author
|
The tests may be flaky. |
vdimir
approved these changes
Jan 14, 2025
Member
vdimir
left a comment
There was a problem hiding this comment.
Great catch, thanks for your contribution!
Contributor
Author
|
Is the CI failure because of the changes in current PR? |
Member
I don't think so, there're many flaky tests currenly |
Merged
via the queue into
ClickHouse:master
with commit Jan 22, 2025
f8710d1
125 of 127 checks passed
ianton-ru
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Feb 14, 2025
Resolve the issue of leaking keeper watches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enable ClusterDiscovery, the count of keeper watch (CurrentMetric_ZooKeeperWatch) will increase indefinitely. It is because ClusterDiscovery will call
getNodeNamesfor each cluster every 2 minites, and it will register a new watch callback object every time, which will lead to a leaking of keeper watches if the cluster never updates. We should always register the same watch callback object instead.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix the bug of leaking keeper watches when enable Cluster Discovery.
Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing)
All builds in Builds_1 and Builds_2 stages are always mandatory
and will run independently of the checks below: