Conversation
…k/add_sequence_id_and_implementation_refactoring
robot-ch-test-poll
added
pr-improvement
Contributor
|
This is an automated comment for commit 1d9bab3 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
Contributor
divanik
changed the title
hanfei1991
reviewed
Feb 26, 2025
Member
hanfei1991
left a comment
hanfei1991
left a comment
There was a problem hiding this comment.
Are we going to add some tests?
src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergMetadata.cpp
Outdated
Show resolved
Hide resolved
Member
Author
I don't think so. I think there is no need to add tests for refactoring part. For part with sequence_number I also don't know how to add tests without checking internal structure of Iceberg which is not desirable, imho |
hanfei1991
approved these changes
Feb 26, 2025
divanik
deleted the
divanik/add_sequence_id_and_implementation_refactoring
branch
ianton-ru
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Apr 11, 2025
…nce_id_and_implementation_refactoring Add sequence id to iceberg metadata and iceberg avro parsing refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Implemented parsing enhancements (Sequence ID parsing: Added functionality to parse sequence identifiers in manifest files AND Avro metadata parsing: Redesigned the Avro metadata parser to be easily extendable for future enhancements)
Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing)
All builds in Builds_1 and Builds_2 stages are always mandatory and will run independently of the checks below: