Allow altering database comment by NamHoaiNguyen · Pull Request #75622 · ClickHouse/ClickHouse

NamHoaiNguyen · 2025-02-05T17:15:10Z

Changelog category (leave one):

New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Allow altering a database comment. Closes #73351

Documentation entry for user-facing changes

Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing)

All builds in Builds_1 and Builds_2 stages are always mandatory and will run independently of the checks below:

Only: Stateless tests
Only: Integration tests
Only: Performance tests

Skip: Style check
Skip: Fast test

Run all checks ignoring all possible failures (Resource-intensive. All test jobs execute in parallel).
Disable CI cache

src/Interpreters/InterpreterAlterQuery.cpp

robot-ch-test-poll · 2025-02-06T08:22:25Z

This is an automated comment for commit 643ebe0 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check name	Description	Status
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	❌ failure

Successful checks

Check name	Description	Status
Docs check	Builds and tests the documentation	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success

clickhouse-gh · 2025-02-07T14:15:04Z

Workflow [PR], commit [d2e0448]

src/Databases/IDatabase.cpp

src/Databases/DatabaseOnDisk.cpp

src/Databases/MySQL/DatabaseMySQL.cpp

src/Interpreters/DatabaseCatalog.cpp

CLAassistant · 2025-02-27T03:41:23Z

All committers have signed the CLA.

src/Interpreters/DatabaseCatalog.cpp

src/Interpreters/InterpreterAlterQuery.cpp

src/Databases/DatabasesCommon.cpp

tuanpach · 2025-03-24T06:11:12Z

PedroTadim · 2025-04-15T15:33:02Z

Hello! I get this error:

Syntax error: failed at position 19 (ON):

ALTER DATABASE d5 ON CLUSTER 'cx' MODIFY COMMENT 'a';

Expected one of: a list of ALTER commands, ALTER command, MODIFY SETTING, MODIFY COMMENT

Should the ON CLUSTER clause be supported for this statement?

tuanpach · 2025-04-16T06:35:31Z

Hello! I get this error:
Syntax error: failed at position 19 (ON):

ALTER DATABASE d5 ON CLUSTER 'cx' MODIFY COMMENT 'a';

Expected one of: a list of ALTER commands, ALTER command, MODIFY SETTING, MODIFY COMMENT
Should the ON CLUSTER clause be supported for this statement?

I will fix it in another PR

…_comment_issue_73351 Allow altering database comment

25.3.8 Backport of ClickHouse#75622: Allow altering database comment

NamHoaiNguyen mentioned this pull request Feb 5, 2025

Allow ALTERing a database comment #73351

Closed

tuanpach reviewed Feb 6, 2025

View reviewed changes

bharatnc added the can be tested Allows running workflows for external contributors label Feb 6, 2025

robot-clickhouse-ci-1 added the pr-feature Pull request with new product feature label Feb 6, 2025

NamHoaiNguyen requested a review from tuanpach February 6, 2025 15:35

NamHoaiNguyen force-pushed the alter_database_comment_issue_73351 branch from 643ebe0 to 9c5dbe1 Compare February 7, 2025 14:14

NamHoaiNguyen force-pushed the alter_database_comment_issue_73351 branch from 141a601 to ac19d49 Compare February 7, 2025 14:23

nikitamikhaylov assigned tuanpach Feb 10, 2025

tuanpach reviewed Feb 11, 2025

View reviewed changes

src/Databases/IDatabase.cpp Outdated Show resolved Hide resolved

NamHoaiNguyen requested a review from tuanpach February 12, 2025 17:00

tuanpach reviewed Feb 12, 2025

View reviewed changes

src/Databases/IDatabase.cpp Outdated Show resolved Hide resolved

NamHoaiNguyen requested a review from tuanpach February 15, 2025 04:13

NamHoaiNguyen force-pushed the alter_database_comment_issue_73351 branch from dc2bbfe to 3d590c7 Compare February 15, 2025 04:16

NamHoaiNguyen changed the title ~~Allow ALTERing a database comment~~ Allow altering database comment Feb 25, 2025

tuanpach reviewed Feb 26, 2025

View reviewed changes

src/Databases/DatabaseOnDisk.cpp Outdated Show resolved Hide resolved

tuanpach reviewed Feb 26, 2025

View reviewed changes

src/Databases/MySQL/DatabaseMySQL.cpp Outdated Show resolved Hide resolved

tuanpach reviewed Feb 26, 2025

View reviewed changes

src/Interpreters/DatabaseCatalog.cpp Outdated Show resolved Hide resolved

NamHoaiNguyen force-pushed the alter_database_comment_issue_73351 branch from b0afa0d to 1dee9ef Compare February 26, 2025 15:53

NamHoaiNguyen force-pushed the alter_database_comment_issue_73351 branch from 206e5a0 to a2eb5e0 Compare February 27, 2025 12:33

NamHoaiNguyen requested a review from tuanpach February 28, 2025 03:44

tuanpach reviewed Feb 28, 2025

View reviewed changes

src/Interpreters/DatabaseCatalog.cpp Outdated Show resolved Hide resolved

tuanpach reviewed Feb 28, 2025

View reviewed changes

src/Interpreters/InterpreterAlterQuery.cpp Outdated Show resolved Hide resolved

tuanpach reviewed Feb 28, 2025

View reviewed changes

src/Interpreters/InterpreterAlterQuery.cpp Outdated Show resolved Hide resolved

NamHoaiNguyen requested a review from tuanpach March 3, 2025 16:53

tuanpach reviewed Mar 4, 2025

View reviewed changes

src/Databases/DatabasesCommon.cpp Outdated Show resolved Hide resolved

tuanpach approved these changes Mar 4, 2025

View reviewed changes

NamHoaiNguyen requested a review from tuanpach March 6, 2025 15:47

NamHoaiNguyen and others added 14 commits March 23, 2025 22:54

Fix style check

585053e

Remove leftover code

284825d

Fix style check again

23157f6

Continue fixing style check

57a42cc

Update code

e559814

Fix style check

fc38ad1

Update throw message

ea5983d

Update feature for database memory and add test

e218dd5

Try to fix docs build

35d1fdc

Fix compilation

e2b9a0b

Fix compilation after updating the branch

bdedac9

Update database-comment.md

5ae224d

Update database-comment.md, fix a broken link

1ff2562

Remove condition for dictionary and fix mysql test

d2e0448

NamHoaiNguyen force-pushed the alter_database_comment_issue_73351 branch from 9d232bc to d2e0448 Compare March 23, 2025 16:20

tuanpach added this pull request to the merge queue Mar 24, 2025

Merged via the queue into ClickHouse:master with commit 93d6ac2 Mar 24, 2025
118 of 125 checks passed

robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 24, 2025

Slach mentioned this pull request Apr 8, 2025

Unable to modify database comment Altinity/clickhouse-operator#1676

Closed

zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Oct 13, 2025

Merge pull request ClickHouse#75622 from NamHoaiNguyen/alter_database…

9e8c5d4

…_comment_issue_73351 Allow altering database comment

zvonand mentioned this pull request Oct 13, 2025

24.8.14 Backport of #75622: Allow altering database comment Altinity/ClickHouse#1073

Closed

25 tasks

zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Oct 30, 2025

Merge pull request ClickHouse#75622 from NamHoaiNguyen/alter_database…

19ee002

…_comment_issue_73351 Allow altering database comment

zvonand mentioned this pull request Oct 30, 2025

25.3.7 Backport of #75622: Allow altering database comment Altinity/ClickHouse#1113

Closed

25 tasks

zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Oct 31, 2025

Merge pull request ClickHouse#75622 from NamHoaiNguyen/alter_database…

1866030

…_comment_issue_73351 Allow altering database comment

zvonand mentioned this pull request Oct 31, 2025

25.3.8 Backport of #75622: Allow altering database comment Altinity/ClickHouse#1118

Merged

25 tasks

zvonand added a commit to Altinity/ClickHouse that referenced this pull request Nov 1, 2025

Merge pull request #1118 from Altinity/backport/25.3.8/75622

6692348

25.3.8 Backport of ClickHouse#75622: Allow altering database comment

Conversation

NamHoaiNguyen commented Feb 5, 2025 • edited by tuanpach Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Documentation entry for user-facing changes

CI Settings (Only check the boxes if you know what you are doing)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robot-ch-test-poll commented Feb 6, 2025 • edited by robot-ch-test-poll4 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clickhouse-gh bot commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CLAassistant commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tuanpach commented Mar 24, 2025

Uh oh!

Uh oh!

PedroTadim commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tuanpach commented Apr 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

NamHoaiNguyen commented Feb 5, 2025 •

edited by tuanpach

Loading

robot-ch-test-poll commented Feb 6, 2025 •

edited by robot-ch-test-poll4

Loading

clickhouse-gh bot commented Feb 7, 2025 •

edited

Loading

CLAassistant commented Feb 27, 2025 •

edited

Loading

PedroTadim commented Apr 15, 2025 •

edited

Loading