added bitmapTransform#7598
Merged
alexey-milovidov merged 6 commits intoClickHouse:masterfrom Nov 4, 2019
infinivision:bitmap_replace
Merged
added bitmapTransform#7598alexey-milovidov merged 6 commits intoClickHouse:masterfrom infinivision:bitmap_replace
alexey-milovidov merged 6 commits intoClickHouse:masterfrom
infinivision:bitmap_replace
Conversation
Collaborator
|
I would name it |
Member
|
+1. It will be also more consistent with |
nvartolomei
reviewed
Nov 3, 2019
Contributor
There was a problem hiding this comment.
The result here is a bit surprising, especially since result depends on array ordering, might be worth explicit mention in docs.
Contributor
Author
There was a problem hiding this comment.
Added a note in doc.
Contributor
Author
Done as you suggested. |
alexey-milovidov
approved these changes
Nov 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
bitmapTransform
Transform an array of values in a bitmap to another array of values, the result is a new bitmap.
Parameters
bitmap– bitmap object.from_array– UInt32 array. For idx in range [0, from_array.size()), if bitmap contains from_array[idx], then replace it with to_array[idx]. Note that the result depends on array ordering if there are common elements between from_array and to_array.to_array– UInt32 array, its size shall be the same to from_array.Example