Check column for __getScalar() (avoids assertion)#7599
Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom Nov 3, 2019
Merged
Check column for __getScalar() (avoids assertion)#7599alexey-milovidov merged 2 commits intoClickHouse:masterfrom
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
Conversation
Can be triggered using the following query:
CREATE TABLE foo (key String, macro String MATERIALIZED __getScalar(key)) Engine=Null();
Trace:
3. 0x00007ffff6d5d526 __assert_fail (libc.so.6)
4. 0x00007ffff41fd931 boost::intrusive_ptr<DB::IColumn const>::operator*() const (libclickhouse_functionsd.so)
5. 0x00007ffff41fcd64 COW<DB::IColumn>::IntrusivePtr<DB::IColumn const>::operator*() const & (libclickhouse_functionsd.so)
6. 0x00007ffff4dc5944 DB::FunctionGetScalar::getReturnTypeImpl() const (libclickhouse_functionsd.so)
(Even though it is internal I guess it is better to fix it)
Refs: ClickHouse#7392
Cc: @amosbird
alexey-milovidov
approved these changes
Nov 3, 2019
alexey-milovidov
requested changes
Nov 3, 2019
Member
alexey-milovidov
left a comment
There was a problem hiding this comment.
Missing functional test.
Member
Author
|
I thought that since it is internal, tests is not needed, anyway added. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category (leave one):
-non-significant
Can be triggered using the following query:
Trace:
(Even though it is internal I guess it is better to fix it)
Refs: #7392
Cc: @amosbird