Skip to content

Made MergeTreeData::cloneAndLoadDataPart only work for the same disk.#7602

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
excitoon-favorites:cloneAndLoadDataPartOnSameDisk
Nov 4, 2019
Merged

Made MergeTreeData::cloneAndLoadDataPart only work for the same disk.#7602
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
excitoon-favorites:cloneAndLoadDataPartOnSameDisk

Conversation

@excitoon
Copy link
Contributor

@excitoon excitoon commented Nov 3, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Bug Fix

Short description (up to few sentences):

Fixed a bug with a mutation on a MergeTree when whole part remains unchanged and best space is being found on another disk.
Fixes #7425.

Copy link
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test?

PS. Probably it's too hard to make proper test?

@alexey-milovidov alexey-milovidov merged commit b261e60 into ClickHouse:master Nov 4, 2019
@alesapin alesapin added pr-bugfix Pull request with bugfix, not backported by default v19.16 labels Nov 8, 2019
alexey-milovidov added a commit that referenced this pull request Nov 21, 2019
Fixed errors with space reservation introduced in #7558 and #7602
tavplubix pushed a commit that referenced this pull request Nov 21, 2019
Fixed errors with space reservation introduced in #7558 and #7602
tavplubix pushed a commit that referenced this pull request Nov 21, 2019
Fixed errors with space reservation introduced in #7558 and #7602
tavplubix pushed a commit that referenced this pull request Nov 21, 2019
Fixed errors with space reservation introduced in #7558 and #7602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MergeTreeDataMergerMutator creates hard links during merge (which is not allowed in multiple disks reality)

4 participants